-
Notifications
You must be signed in to change notification settings - Fork 592
HDDS-12395. Add Mismatched Replica tab to the Containers Page #8407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dombizita @devmadhuu @ArafatKhan2198 Could you help taking a look at this patch? |
dombizita
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @devabhishekpal! I checked the UI locally, overall it looks good. Could you please try to show the data checksum value next to the datanodes? It'd be great if we could show on the UI what the container data checksum is on each datanode (we are not able to tell which one is correct, but that's fine).
...econ/src/main/resources/webapps/recon/ozone-recon-web/src/v2/pages/containers/containers.tsx
Outdated
Show resolved
Hide resolved
|
Hi @dombizita thanks for the inputs. |
dombizita
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the review comments @devabhishekpal! I have one minor comment, otherwise it looks good to me! I checked it locally, it works fine! I tested what happens if one datanode misses the dataChecksum value and what happens if none of the datanodes have it, it's good all the way!
The HDDS-10239-container-reconciliation branch is merged in the meantime (sorry for coming back late with the review) could you please raise the PR against master?
...rc/main/resources/webapps/recon/ozone-recon-web/src/v2/components/tables/containersTable.tsx
Outdated
Show resolved
Hide resolved
|
HDDS-10239-container-reconciliation is merged into |
Co-authored-by: Zita Dombi <[email protected]>
|
Thanks for the approval @dombizita. @ArafatKhan2198 @devmadhuu could you help taking a look at this PR as well? |
What changes were proposed in this pull request?
This PR adds the tab in the container page for Mismatched Replicas.
Please describe your PR in detail:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12395
How was this patch tested?
This patch was tested manually.
Screen.Recording.2025-05-28.at.13.15.12.mp4