Skip to content

Conversation

@devabhishekpal
Copy link
Contributor

@devabhishekpal devabhishekpal commented May 7, 2025

What changes were proposed in this pull request?

This PR adds the tab in the container page for Mismatched Replicas.

Please describe your PR in detail:

  • As a part of the new reconciler feature we are able to detect mismatched replicas in Ozone
  • This PR is a UI change to add the respective tab in the container page along

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12395

How was this patch tested?

This patch was tested manually.

Screen.Recording.2025-05-28.at.13.15.12.mp4
Screenshot 2025-06-23 at 14 00 31

@devabhishekpal devabhishekpal marked this pull request as ready for review May 28, 2025 07:44
@devabhishekpal
Copy link
Contributor Author

@dombizita @devmadhuu @ArafatKhan2198 Could you help taking a look at this patch?
Tested it out on the local environment.
Updated the mocked response with the mismatched container response section as well

Copy link
Contributor

@dombizita dombizita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @devabhishekpal! I checked the UI locally, overall it looks good. Could you please try to show the data checksum value next to the datanodes? It'd be great if we could show on the UI what the container data checksum is on each datanode (we are not able to tell which one is correct, but that's fine).

@devabhishekpal
Copy link
Contributor Author

Hi @dombizita thanks for the inputs.
I addressed the rename suggestion and also added the new Checksum field to the datanode column
Attached the screenshot for the same.
Could you help take another look?
Thanks

Copy link
Contributor

@dombizita dombizita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the review comments @devabhishekpal! I have one minor comment, otherwise it looks good to me! I checked it locally, it works fine! I tested what happens if one datanode misses the dataChecksum value and what happens if none of the datanodes have it, it's good all the way!
The HDDS-10239-container-reconciliation branch is merged in the meantime (sorry for coming back late with the review) could you please raise the PR against master?

@aswinshakil
Copy link
Member

HDDS-10239-container-reconciliation is merged into master. Please merge this change into master and any other future changes into master

@devabhishekpal devabhishekpal changed the base branch from HDDS-10239-container-reconciliation to master June 26, 2025 13:56
@devabhishekpal
Copy link
Contributor Author

Thanks for the approval @dombizita.
I removed the brackets from the checksum for the tooltip.

@ArafatKhan2198 @devmadhuu could you help taking a look at this PR as well?

@ArafatKhan2198 ArafatKhan2198 merged commit 9b713d0 into apache:master Jul 7, 2025
66 of 67 checks passed
@devabhishekpal devabhishekpal deleted the HDDS-12395 branch July 7, 2025 08:33
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants