Skip to content

HDDS-12973. Add java doc for CompactionNode constructor and make getCompactionNodeGraph return ConcurrentMap #8395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 1 commit into from
May 7, 2025
Merged

HDDS-12973. Add java doc for CompactionNode constructor and make getCompactionNodeGraph return ConcurrentMap #8395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...ds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/CompactionNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ public class CompactionNode {
private final String endKey;
private final String columnFamily;

/**
* CompactionNode constructor.
* @param file SST file (filename without extension)
* @param seqNum Snapshot generation (sequence number)
*/
public CompactionNode(String file, long seqNum, String startKey, String endKey, String columnFamily) {
fileName = file;
totalNumberOfKeys = 0L;
Expand Down
4 changes: 2 additions & 2 deletions ...b-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,8 +1205,8 @@ public boolean shouldRun() {
}

@VisibleForTesting
public ConcurrentHashMap<String, CompactionNode> getCompactionNodeMap() {
return (ConcurrentHashMap<String, CompactionNode>) compactionDag.getCompactionMap();
public ConcurrentMap<String, CompactionNode> getCompactionNodeMap() {
return compactionDag.getCompactionMap();
}

@VisibleForTesting
Expand Down
3 changes: 1 addition & 2 deletions ...eckpoint-differ/src/test/java/org/apache/ozone/rocksdiff/TestRocksDBCheckpointDiffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@
import java.util.Optional;
import java.util.Set;
import java.util.UUID;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.ExecutorService;
Expand Down Expand Up @@ -1146,7 +1145,7 @@ private void traverseGraph(
}

private void printMutableGraphFromAGivenNode(
ConcurrentHashMap<String, CompactionNode> compactionNodeMap,
ConcurrentMap<String, CompactionNode> compactionNodeMap,
String fileName,
int sstLevel,
MutableGraph<CompactionNode> mutableGraph) {
Expand Down