HDDS-12846. Log DatanodeDetails instead of DatanodeDetails.getUuidString

hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/ClosePipelineCommandHandler.java

@@ -140,18 +140,18 @@ public void handle(SCMCommand<?> command, OzoneContainer ozoneContainer,
           // well. It is a no-op for XceiverServerSpi implementations (e.g. XceiverServerGrpc)
           server.removeGroup(pipelineIdProto);
           LOG.info("Close Pipeline {} command on datanode {}.", pipelineID,
-              dn.getUuidString());
+              dn);
         } else {
           LOG.debug("Ignoring close pipeline command for pipeline {} on datanode {} " +
-              "as it does not exist", pipelineID, dn.getUuidString());
+              "as it does not exist", pipelineID, dn);
         }
       } catch (IOException e) {
         Throwable gme = HddsClientUtils.containsException(e, GroupMismatchException.class);
         if (gme != null) {
           // ignore silently since this means that the group has been closed by earlier close pipeline
           // command in another datanode
           LOG.debug("The group for pipeline {} on datanode {} has been removed by earlier close " +
-              "pipeline command handled in another datanode", pipelineID, dn.getUuidString());
+              "pipeline command handled in another datanode", pipelineID, dn);
         } else {
           LOG.error("Can't close pipeline {}", pipelineID, e);
         }

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/HealthyReadOnlyNodeHandler.java

@@ -88,7 +88,7 @@ public void onMessage(DatanodeDetails datanodeDetails,
                 "containers.",
             pipelineID, pipeline.getPipelineState(),
             HddsProtos.NodeState.HEALTHY_READONLY,
-            datanodeDetails.getUuidString());
+            datanodeDetails);
         pipelineManager.closePipeline(pipelineID);
       } catch (IOException ex) {
         LOG.error("Failed to close pipeline {} which uses HEALTHY READONLY " +

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineActionHandler.java

@@ -75,7 +75,7 @@ private void processPipelineAction(final DatanodeDetails datanode,
     final PipelineID pid = PipelineID.getFromProtobuf(info.getPipelineID());
 
     final String logMsg = "Received pipeline action " + action + " for " + pid +
-        " from datanode " + datanode.getUuidString() + "." +
+        " from datanode " + datanode + "." +
         " Reason : " + info.getDetailedReason();
 
     // We can skip processing Pipeline Action if the current SCM is not leader.

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineManagerImpl.java

@@ -547,7 +547,7 @@ public void closeStalePipelines(DatanodeDetails datanodeDetails) {
             getStalePipelines(datanodeDetails);
     if (pipelinesWithStaleIpOrHostname.isEmpty()) {
       LOG.debug("No stale pipelines for datanode {}",
-              datanodeDetails.getUuidString());
+              datanodeDetails);
       return;
     }
     LOG.info("Found {} stale pipelines",

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipelineProvider.java

@@ -201,7 +201,7 @@ public synchronized Pipeline create(RatisReplicationConfig replicationConfig,
 
     dns.forEach(node -> {
       LOG.info("Sending CreatePipelineCommand for pipeline:{} to datanode:{}",
-          pipeline.getId(), node.getUuidString());
+          pipeline.getId(), node);
       eventPublisher.fireEvent(SCMEvents.DATANODE_COMMAND,
           new CommandForDatanode<>(node.getUuid(), createCommand));
     });

hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/upgrade/TestHDDSUpgrade.java

@@ -409,7 +409,7 @@ private Boolean injectDataNodeFailureDuringSCMUpgrade() {
           new ArrayList<>(cluster.getHddsDatanodes());
       for (HddsDatanodeService ds: currentDataNodes) {
         DatanodeDetails dn = ds.getDatanodeDetails();
-        LOG.info("Restarting datanode {}", dn.getUuidString());
+        LOG.info("Restarting datanode {}", dn);
         cluster.restartHddsDatanode(dn, false);
       }
       cluster.waitForClusterToBeReady();

hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconNewNodeHandler.java

@@ -45,7 +45,7 @@ public void onMessage(DatanodeDetails datanodeDetails,
       nodeManager.addNodeToDB(datanodeDetails);
     } catch (IOException e) {
       LOG.error("Unable to add new node {} to Node DB.",
-          datanodeDetails.getUuidString());
+          datanodeDetails);
     }
   }
 }

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/DatanodeSimulator.java

@@ -337,7 +337,7 @@ private boolean startDatanode(DatanodeSimulationState dn)
       throws IOException {
     if (!registerDataNode(dn)) {
       LOGGER.info("Failed to register datanode to SCM: {}",
-          dn.getDatanodeDetails().getUuidString());
+          dn.getDatanodeDetails());
       return false;
     }
 
@@ -359,7 +359,7 @@ private boolean startDatanode(DatanodeSimulationState dn)
         reconHeartbeatInterval, TimeUnit.MILLISECONDS);
 
     LOGGER.info("Successfully registered datanode to SCM: {}",
-        dn.getDatanodeDetails().getUuidString());
+        dn.getDatanodeDetails());
     return true;
   }
 
@@ -418,7 +418,7 @@ private void heartbeat(InetSocketAddress endpoint,
       }
     } catch (Exception e) {
       LOGGER.info("Error sending heartbeat for {}: {}",
-          dn.getDatanodeDetails().getUuidString(), e.getMessage(), e);
+          dn.getDatanodeDetails(), e.getMessage(), e);
     }
   }