Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ public class OzoneClientConfig {

@Config(key = "ozone.client.ec.reconstruct.stripe.read.pool.limit",
defaultValue = "30",
description = "Thread pool max size for parallelly read" +
description = "Thread pool max size for parallel read" +
" available ec chunks to reconstruct the whole stripe.",
tags = ConfigTag.CLIENT)
// For the largest recommended EC policy rs-10-4-1024k,
Expand All @@ -205,7 +205,7 @@ public class OzoneClientConfig {

@Config(key = "ozone.client.ec.reconstruct.stripe.write.pool.limit",
defaultValue = "30",
description = "Thread pool max size for parallelly write" +
description = "Thread pool max size for parallel write" +
" available ec chunks to reconstruct the whole stripe.",
tags = ConfigTag.CLIENT)
private int ecReconstructStripeWritePoolLimit = 10 * 3;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ public HeartbeatEndpointTask build() {

if (conf == null) {
LOG.error("No config specified.");
throw new IllegalArgumentException("A valid configration is needed to" +
throw new IllegalArgumentException("A valid configuration is needed to" +
" construct HeartbeatEndpointTask task");
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ private static String[] parseFormDataParameters(HttpServletRequest request) {
sstParam.add(Streams.asString(item.openStream()));
}
} catch (Exception e) {
LOG.warn("Exception occured during form data parsing {}", e.getMessage());
LOG.warn("Exception occurred during form data parsing {}", e.getMessage());
}

return sstParam.isEmpty() ? null : sstParam.toArray(new String[0]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ public synchronized void getMetrics(MetricsCollector collector, boolean all) {
// exposing internal representation. FindBugs error raised.
private MutableQuantiles[] grpcQueueTimeMillisQuantiles;

@Metric("Processsing time")
@Metric("Processing time")
private MutableRate grpcProcessingTime;

// There should be no getter method to avoid
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ private synchronized StatusAndMessages initFinalize(
private void assertClientId(String id) throws UpgradeException {
if (this.clientID == null || !this.clientID.equals(id)) {
throw new UpgradeException("Unknown client tries to get finalization " +
"status.\n The requestor is not the initiating client of the " +
"status.\n The requester is not the initiating client of the " +
"finalization, if you want to take over, and get unsent status " +
"messages, check -takeover option.", INVALID_REQUEST);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public void testRequestQuoting() throws Exception {

doReturn(null).when(mockReq).getParameter("x");
assertNull(quoter.getParameter("x"),
"Test that missing parameters dont cause NPE");
"Test that missing parameters don't cause NPE");

doReturn(new String[] {"a<b", "b"}).when(mockReq)
.getParameterValues("x");
Expand All @@ -95,6 +95,6 @@ public void testRequestQuoting() throws Exception {

doReturn(null).when(mockReq).getParameterValues("x");
assertNull(quoter.getParameterValues("x"),
"Test that missing parameters dont cause NPE for array");
"Test that missing parameters don't cause NPE for array");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ private DatanodeDetails chooseNode(List<DatanodeDetails> excludedNodes,
if (maxRetry == 0) {
// avoid the infinite loop
String errMsg = "No satisfied datanode to meet the space constrains. "
+ "metadatadata size required: " + metadataSizeRequired +
+ "metadata size required: " + metadataSizeRequired +
" data size required: " + dataSizeRequired;
LOG.info(errMsg);
throw new SCMException(errMsg, null);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ private Node chooseNode(String scope, List<Node> excludedNodes,
if (maxRetry == 0) {
// avoid the infinite loop
LOG.info("No satisfied datanode to meet the constraints. "
+ "Metadatadata size required: {} Data size required: {}, scope "
+ "Metadata size required: {} Data size required: {}, scope "
+ "{}, excluded nodes {}",
metadataSizeRequired, dataSizeRequired, scope, excludedNodes);
return null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public static List<DatanodeDetails> getTargetDatanodes(PlacementPolicy policy,
}
}
throw new SCMException(String.format("Placement Policy: %s did not return"
+ " any nodes. Number of required Nodes %d, Datasize Required: %d",
+ " any nodes. Number of required Nodes %d, Data size Required: %d",
policy.getClass(), requiredNodes, dataSizeRequired),
SCMException.ResultCodes.FAILED_TO_FIND_SUITABLE_NODE);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ private void parseHostname() throws InvalidHostStringException {
}
} catch (URISyntaxException e) {
throw new InvalidHostStringException(
"Unable to parse the hoststring " + rawHostname, e);
"Unable to parse the host string " + rawHostname, e);
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ keyName, partIndex, getLength(), numBytesToRead,
LOG.debug("OzoneCryptoInputStream for key: {} part: {} read {} bytes " +
"instead of {} bytes to account for Crypto buffer boundary. " +
"Client buffer will be copied with read data from position {}" +
"upto position {}, discarding the extra bytes read to " +
"up to position {}, discarding the extra bytes read to " +
"maintain Crypto buffer boundary limits", keyName, partIndex,
actualNumBytesRead, numBytesRead, readPositionAdjustedBy,
actualNumBytesRead - readPositionAdjustedBy);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@ public static void verifyMaxKeyLength(String length)
maxKey = Integer.parseInt(length);
} catch (NumberFormatException nfe) {
throw new IllegalArgumentException(
"Invalid max key length, the vaule should be digital.");
"Invalid max key length, the value should be digital.");
}

if (maxKey <= 0) {
throw new IllegalArgumentException(
"Invalid max key length, the vaule should be a positive number.");
"Invalid max key length, the value should be a positive number.");
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public void teardown() throws Exception {
LOG.info("Statistics {}",
ioStatisticsSourceToString(uploader));
} catch (Exception e) {
LOG.warn("Exeception in teardown", e);
LOG.warn("Exception in teardown", e);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ public void testTrackDeepDirectoryStructureToRemote() throws Exception {
.withDirectWrite(shouldUseDirectWrite())
.withOverwrite(false)));

lsR("tracked udpate", remoteFS, destDir);
lsR("tracked update", remoteFS, destDir);
// new file went over
Path outputFileNew1 = new Path(outputSubDir2, "newfile1");
ContractTestUtils.assertIsFile(remoteFS, outputFileNew1);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ protected SCMHAService createSCMService()
scm.getClientRpcAddress());
} else {
inactiveSCMs.add(scm);
LOG.info("Intialized SCM at {}. This SCM is currently "
LOG.info("Initialized SCM at {}. This SCM is currently "
+ "inactive (not running).", scm.getClientRpcAddress());
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1590,7 +1590,7 @@ private void initializeRatisDirs(OzoneConfiguration conf) throws IOException {
throw new IOException(
"Path of " + OMConfigKeys.OZONE_OM_RATIS_STORAGE_DIR + " and "
+ ScmConfigKeys.OZONE_SCM_HA_RATIS_STORAGE_DIR
+ " should not be co located. Please change atleast one path.");
+ " should not be co located. Please change at least one path.");
}

// Create Ratis snapshot dir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public void initialize(Configuration conf, FileSystem fs) {
* MSECS_PER_MINUTE);
if (deletionInterval < 0) {
LOG.warn("Invalid value {} for deletion interval,"
+ " deletion interaval can not be negative."
+ " deletion interval can not be negative."
+ "Changing to default value 0", deletionInterval);
this.deletionInterval = 0;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ public synchronized void unpause(long newLastAppliedSnaphsotIndex,
this.setLastAppliedTermIndex(TermIndex.valueOf(
newLastAppliedSnapShotTermIndex, newLastAppliedSnaphsotIndex));
LOG.info("{}: OzoneManagerStateMachine un-pause completed. " +
"newLastAppliedSnaphsotIndex: {}, newLastAppliedSnapShotTermIndex: {}",
"newLastAppliedSnapshotIndex: {}, newLastAppliedSnapShotTermIndex: {}",
getId(), newLastAppliedSnaphsotIndex, newLastAppliedSnapShotTermIndex);
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, Execut
//Check if bucket exist
if (omBucketInfo == null) {
LOG.debug("Bucket: {} not found ", bucketName);
throw new OMException("Bucket doesnt exist",
throw new OMException("Bucket doesn't exist",
OMException.ResultCodes.BUCKET_NOT_FOUND);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ private boolean displayTable(ManagedRocksIterator iterator,
boolean flg = parentFile.mkdirs();
if (!flg) {
throw new IOException("An exception occurred while creating " +
"the directory. Directorys: " + parentFile.getAbsolutePath());
"the directory. Directory: " + parentFile.getAbsolutePath());
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public class FollowerAppendLogEntryGenerator extends BaseAppendLogGenerator

@Option(names = {"-i", "--next-index"},
description = "The next index in the term 2 to continue a test. (If "
+ "zero, a new ratis ring will be intialized with configureGroup "
+ "zero, a new ratis ring will be initialized with configureGroup "
+ "call and vote)",
defaultValue = "0")
private long nextIndex;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public class LeaderAppendLogEntryGenerator extends BaseAppendLogGenerator

@Option(names = {"-i", "--next-index"},
description = "The next index in the term 2 to continue a test. (If "
+ "zero, a new ratis ring will be intialized with configureGroup "
+ "zero, a new ratis ring will be initialized with configureGroup "
+ "call and vote)",
defaultValue = "0")
private long nextIndex;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
* Container generator for SCM metadata.
*/
@Command(name = "cgscm",
description = "Offline container metadata generator for Storage Conainer "
description = "Offline container metadata generator for Storage Container "
+ "Manager",
versionProvider = HddsVersionProvider.class,
mixinStandardHelpOptions = true,
Expand Down