-
Notifications
You must be signed in to change notification settings - Fork 589
HDDS-12697. Ozone debug CLI command to display details of a single container #8264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e0c6f2e
HDDS-12697. CLI command to display details of a single container
e05e9d1
Fixed pmd and formatting issues
56e8773
Added container info command
6cd0f63
Updated command logic
48796fe
Used kebab case for subcommand and added javadoc
d75979b
Updated the command logic
8e537b2
Updated command logic and simplified error handling
7f112dc
Moved container issue checks to helper method
807cbd8
fixed pmd issue
8eaf265
Added container ID validation and sorted SQL by datanode ID for bette…
bc05829
Updated logic for analysis
a00f24d
Fixed checkstyle
e437b94
Merged HDDS-12599 into HDDS-12697
sreejasahithi 1c6b9b2
Updated container info command
cd53f4b
Refactored to use AbstractSubcommand for output handling and moved fi…
d76d9f8
Updated analyzeContainerHealth, improved exceptions, and used PrintWr…
22d6e67
Fixed pmd issue
c2d025f
Removed unused code
bfbf14e
Centralized DB path validation logic
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
291 changes: 0 additions & 291 deletions
291
.../src/main/java/org/apache/hadoop/ozone/containerlog/parser/ContainerDatanodeDatabase.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
...ools/src/main/java/org/apache/hadoop/ozone/debug/logs/container/ContainerInfoCommand.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.ozone.debug.logs.container; | ||
|
|
||
| import java.nio.file.Files; | ||
| import java.nio.file.Path; | ||
| import java.nio.file.Paths; | ||
| import java.util.concurrent.Callable; | ||
| import org.apache.hadoop.hdds.cli.AbstractSubcommand; | ||
| import org.apache.hadoop.ozone.debug.logs.container.utils.ContainerDatanodeDatabase; | ||
| import org.apache.hadoop.ozone.debug.logs.container.utils.SQLDBConstants; | ||
| import picocli.CommandLine; | ||
|
|
||
| /** | ||
| * Command to display detailed information of a single container by ID. | ||
| */ | ||
|
|
||
| @CommandLine.Command( | ||
| name = "info", | ||
| description = "Provides complete state transition history of each replica for a single container along with " + | ||
| "analysis over the container" | ||
| ) | ||
| public class ContainerInfoCommand extends AbstractSubcommand implements Callable<Void> { | ||
|
|
||
| @CommandLine.Parameters(index = "0", description = "Container ID") | ||
| private Long containerId; | ||
|
|
||
| @CommandLine.ParentCommand | ||
| private ContainerLogController parent; | ||
|
|
||
| @Override | ||
| public Void call() throws Exception { | ||
|
|
||
| if (containerId < 0) { | ||
| err().println("Invalid container ID: " + containerId); | ||
| return null; | ||
| } | ||
|
|
||
| Path providedDbPath; | ||
| if (parent.getDbPath() == null) { | ||
| providedDbPath = Paths.get(System.getProperty("user.dir"), SQLDBConstants.DEFAULT_DB_FILENAME); | ||
|
|
||
| if (Files.exists(providedDbPath) && Files.isRegularFile(providedDbPath)) { | ||
| out().println("Using default database file found in current directory: " + providedDbPath); | ||
| } else { | ||
| err().println("No database path provided and default file '" + SQLDBConstants.DEFAULT_DB_FILENAME + "' not " + | ||
| "found in current directory. Please provide a valid database path"); | ||
| return null; | ||
| } | ||
| } else { | ||
| providedDbPath = Paths.get(parent.getDbPath()); | ||
| Path parentDir = providedDbPath.getParent(); | ||
|
|
||
| if (parentDir != null && !Files.exists(parentDir)) { | ||
| err().println("The parent directory of the provided database path does not exist: " + parentDir); | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| ContainerDatanodeDatabase.setDatabasePath(providedDbPath.toString()); | ||
|
|
||
| ContainerDatanodeDatabase cdd = new ContainerDatanodeDatabase(); | ||
|
||
|
|
||
| cdd.showContainerDetails(containerId); | ||
|
|
||
| return null; | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--dbis inherited from the parent command, but validation is duplicated among subcommands. It should be done inContainerLogController.