Skip to content

HDDS-12755. Redundant declaration in TestHadoopNestedDirGenerator#spanCheck() #8218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aryangupta1998 merged 2 commits into from
Apr 10, 2025
Merged

HDDS-12755. Redundant declaration in TestHadoopNestedDirGenerator#spanCheck() #8218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
662bfc8
HDDS-12755. Redundant declaration in TestHadoopNestedDirGenerator#spa…
chiacyu Apr 2, 2025
ee4f042
Applied comments
chiacyu Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions ...ration-test/src/test/java/org/apache/hadoop/ozone/freon/TestHadoopNestedDirGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,10 @@ private void verifyDirTree(String volumeName, String bucketName,
// verify root path details
FileStatus[] fileStatuses = fileSystem.listStatus(rootDir);
Path p = null;
for (FileStatus fileStatus : fileStatuses) {
// verify the num of peer directories and span directories
p = depthBFS(fileSystem, fileStatuses, span, actualDepth);
int actualSpan = spanCheck(fileSystem, span, p);
assertEquals(span, actualSpan, "Mismatch span in a path");
}
// verify the num of peer directories and span directories
p = depthBFS(fileSystem, fileStatuses, span, actualDepth);
int actualSpan = spanCheck(fileSystem, p);
assertEquals(span, actualSpan, "Mismatch span in a path");
}
}

Expand Down Expand Up @@ -143,14 +141,8 @@ private Path depthBFS(FileSystem fs, FileStatus[] fileStatuses,
* and count the span directories.
*/

private int spanCheck(FileSystem fs, int span, Path p) throws IOException {
private int spanCheck(FileSystem fs, Path p) throws IOException {
int sp = 0;
int depth = 0;
if (span >= 0) {
depth = 0;
} else {
LOG.info("Span value can never be negative");
}
FileStatus[] fileStatuses = fs.listStatus(p);
for (FileStatus fileStatus : fileStatuses) {
if (fileStatus.isDirectory()) {
Expand Down