HDDS-12745. Container checksum should be reported during container close and DN restart #8204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ose and DN restart
errose28
reviewed
Apr 4, 2025
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks for fixing this @aswinshakil. Are there some existing container replication tests we can augment to test this as well?
...e/src/main/java/org/apache/hadoop/ozone/container/checksum/ContainerChecksumTreeManager.java
Outdated
Show resolved
Hide resolved
...st/src/test/java/org/apache/hadoop/ozone/dn/checksum/TestContainerCommandReconciliation.java
Outdated
Show resolved
Hide resolved
...st/src/test/java/org/apache/hadoop/ozone/dn/checksum/TestContainerCommandReconciliation.java
Show resolved
Hide resolved
hemantk-12
reviewed
Apr 11, 2025
Contributor
hemantk-12
left a comment
hemantk-12
left a comment
There was a problem hiding this comment.
Thanks, @aswinshakil for the patch. Overall looks good to me apart from the existing comments.
...st/src/test/java/org/apache/hadoop/ozone/dn/checksum/TestContainerCommandReconciliation.java
Outdated
Show resolved
Hide resolved
kerneltime
approved these changes
Apr 11, 2025
Member
Author
|
Filed HDDS-12824 to optimize container checksum read during DN startup. |
errose28
reviewed
Apr 14, 2025
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Just a few minor comments. Functionality LGTM when accounting for the follow up jira
...e/src/main/java/org/apache/hadoop/ozone/container/checksum/ContainerChecksumTreeManager.java
Show resolved
Hide resolved
...c/test/java/org/apache/hadoop/ozone/container/checksum/TestContainerChecksumTreeManager.java
Show resolved
Hide resolved
...st/src/test/java/org/apache/hadoop/ozone/dn/checksum/TestContainerCommandReconciliation.java
Outdated
Show resolved
Hide resolved
errose28
approved these changes
Apr 14, 2025
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks for the fix. LGTM.
aswinshakil
merged commit 8768d04
into
apache:HDDS-10239-container-reconciliation
43 checks passed
errose28
added a commit
to errose28/ozone
that referenced
this pull request
May 6, 2025
…anner-builds-mt * HDDS-10239-container-reconciliation: HDDS-12849. On demand container scanner should not be static (apache#8296) HDDS-12745. Container checksum should be reported during container close and DN restart (apache#8204) Conflicts: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OnDemandContainerDataScanner.java hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerSet.java hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/ozoneimpl/TestOnDemandContainerDataScanner.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
KeyValueContainerDatahence the SCM doesn't get the checksum.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12745
How was this patch tested?
Integration Test