Skip to content

HDDS-11107. Remove unnecessary run_test_scripts call in upgrade tests #8201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 2 commits into from
Apr 1, 2025
Merged

HDDS-11107. Remove unnecessary run_test_scripts call in upgrade tests #8201

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
805e381
HDDS-11107, remove unnecessary run test command
Jimmyweng006 Mar 30, 2025
6b8f654
HDDS-11107. Keep the test result in $RESULT
Jimmyweng006 Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions hadoop-ozone/dist/src/main/compose/upgrade/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ source "$TEST_DIR/testlib.sh"
export TEST_DIR
export COMPOSE_DIR="$TEST_DIR"

RESULT=0
run_test_scripts ${tests} || RESULT=$?

RESULT_DIR="$ALL_RESULT_DIR" create_results_dir

# Upgrade tests to be run. In CI we want to run just one set, but for a release
Expand All @@ -44,4 +41,4 @@ run_test ha non-rolling-upgrade 1.4.1 "$OZONE_CURRENT_VERSION"

generate_report "upgrade" "$ALL_RESULT_DIR"

exit "$RESULT"
exit "$?"

@adoroszlai adoroszlai Mar 31, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep exit "$RESULT". The variable is set in run_test.

@Jimmyweng006 Jimmyweng006 Apr 1, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh thanks for pointing out, "$?" will only keep the latest command result...

let me change it back and also try to align commit message style