Skip to content

HDDS-12711. Change log level to debug to print excluded SST Files during bootstrap #8186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 8 commits into from
Apr 3, 2025
Merged

HDDS-12711. Change log level to debug to print excluded SST Files during bootstrap #8186

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
14bfc8a
HDDS-12711. Change log level to debug to print excluded SST Files dur…
chiacyu Mar 29, 2025
0350384
Appied comments
chiacyu Mar 29, 2025
1ffec5b
Fixed styles
chiacyu Mar 29, 2025
af54dc5
Applied comments
chiacyu Mar 29, 2025
776c5d2
Applied comments
chiacyu Apr 3, 2025
ae2f7f2
Applied comments
chiacyu Apr 3, 2025
97c2ed3
Applied comments
chiacyu Apr 3, 2025
cc21276
Changed the sample msg content
chiacyu Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,11 @@ private void generateSnapshotCheckpoint(HttpServletRequest request,
.filter(s -> s.endsWith(ROCKSDB_SST_SUFFIX))
.distinct()
.collect(Collectors.toList()));
LOG.info("Received excluding SST {}", receivedSstList);
LOG.info("Received excluding SST {}. The total excluded sst files count is {}",
receivedSstList.subList(0, Math.min(5, receivedSstList.size())), receivedSstList.size());
if (LOG.isDebugEnabled()) {
LOG.debug("Received excluding SST {}", receivedSstList);
}
Copy link
Contributor

@adoroszlai adoroszlai Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits:

  1. Put quick info at the start, details later. In this specific case: show count first, items afterwards. Something like: "Received list of {} SST files to be excluded, sample: {}", count, sublist)
  2. Avoid duplication. Please extract and reuse logic for getting the sublist.
  3. I think logging one message, debug or info, is enough. Message can be almost the same, just omit , sample. Construct the message by extracting the common parts.

}

Path tmpdir = null;
Expand Down Expand Up @@ -229,9 +233,11 @@ private void generateSnapshotCheckpoint(HttpServletRequest request,
long duration = Duration.between(start, end).toMillis();
LOG.info("Time taken to write the checkpoint to response output " +
"stream: {} milliseconds", duration);

LOG.info("Excluded SST {} from the latest checkpoint.",
excludedSstList);
LOG.info("Excluded SST {} from the latest checkpoint. The total excluded sst files count is {}",
excludedSstList.subList(0, Math.min(5, excludedSstList.size())), excludedSstList.size());
if (LOG.isDebugEnabled()) {
LOG.debug("Excluded SST {} from the latest checkpoint.", excludedSstList);
}
if (!excludedSstList.isEmpty()) {
dbMetrics.incNumIncrementalCheckpoint();
}
Expand Down