Skip to content

HDDS-12650. Added logs to SnapshotDeletingService to indicate skipped snapshots. #8123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hemantk-12 merged 5 commits into from
Mar 25, 2025
Merged

HDDS-12650. Added logs to SnapshotDeletingService to indicate skipped snapshots. #8123

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
690609d
HDDS-12650. Added logs to SnapshotDeletingService to indicate skipped…
Mar 20, 2025
72df2fe
HDDS-12650. Addressed comments.
Mar 21, 2025
cb38067
Fixed log message.
hemantk-12 Mar 21, 2025
1b34eac
Revert "Fixed log message."
Mar 21, 2025
ca20ad6
Merge branch 'apache:master' into HDDS-12650
SaketaChalamchala Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...one-manager/src/main/java/org/apache/hadoop/ozone/om/service/SnapshotDeletingService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@ public BackgroundTaskResult call() throws InterruptedException {
while (iterator.hasNext() && snapshotLimit > 0 && remaining > 0) {
SnapshotInfo snapInfo = SnapshotUtils.getSnapshotInfo(ozoneManager, chainManager, iterator.next());
if (shouldIgnoreSnapshot(snapInfo)) {
LOG.debug("Skipping Snapshot Deletion processing because " +
"the snapshot is active or DB changes are not flushed: {}", snapInfo.getTableKey());
continue;
}
LOG.info("Started Snapshot Deletion Processing for snapshot : {}", snapInfo.getTableKey());
Expand All @@ -173,13 +175,19 @@ public BackgroundTaskResult call() throws InterruptedException {
// another.
if (nextSnapshot != null &&
nextSnapshot.getSnapshotStatus() != SnapshotInfo.SnapshotStatus.SNAPSHOT_ACTIVE) {
LOG.info("Skipping Snapshot Deletion processing for : {} because the next snapshot is DELETED.",
snapInfo.getTableKey());
continue;
}

// nextSnapshot = null means entries would be moved to AOS.
if (nextSnapshot == null) {
LOG.info("Snapshot: {} entries will be moved to AOS.", snapInfo.getTableKey());
waitForKeyDeletingService();
waitForDirDeletingService();
} else {
LOG.info("Snapshot: {} entries will be moved to next active snapshot: {}",
snapInfo.getTableKey(), nextSnapshot.getTableKey());
}
try (ReferenceCounted<OmSnapshot> snapshot = omSnapshotManager.getSnapshot(
snapInfo.getVolumeName(), snapInfo.getBucketName(), snapInfo.getName())) {
Expand Down