HDDS-12476. Add TestDataUtil#createKey variant with small random content #8028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Mar 8, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @chiacyu for the patch.
Comment on lines
108
to
111
| public static byte[] createKey(OzoneBucket bucket, | ||
| String keyName, int length) throws IOException { | ||
| byte[] content = RandomStringUtils.random(length, 0, 0, | ||
| true, true, null, new SecureRandom()).getBytes(UTF_8); |
Contributor
There was a problem hiding this comment.
- Let's clarify that this method generates string content by renaming to
createStringKey. - Please avoid
new SecureRandom()ornew Random()for single use. Replace withRandomStringUtils.secure().nextAlphanumeric(length).getBytes(UTF_8). - nit: Please do not format method signature like this. Whenever visibility / return type / method name / other modifiers are changed, we would have to reindent all parameters.
adoroszlai
approved these changes
Mar 8, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @chiacyu for updating the patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Several callers of
TestDataUtil#createKeyjust want to write some data, without any interest in the content being written. The goal of this task is to create a variant of the method which generates some small randombyte[] contentinstead of accepting it via parameter. To let the caller verify data (e.g. viareadKey), this variant ofcreateKeyshould return the random content it generated. Please take a look, thanks!What is the link to the Apache JIRA
HDDS-12476
How was this patch tested?
Tested by CI.