-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-1701. Move dockerbin script to libexec. #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/retest |
|
When test-all.sh is ran in distribution, it works well. |
|
Seems to be working for me even with |
|
/retest |
|
No idea what's wrong here, but I am not brave enough to commit it without understanding the reason of the acceptance test failure. Let me try to find the root cause... |
Yes, thanks @elek for the review. |
|
Ok. I found the problem. The changed Dockerfile is used only to create images for k8s deployment. To change the PATH in the ozone-runner image, a new PR should be created in hadoop-ozone-docker repository (ozone-runner branch): https://github.com/apache/hadoop-docker-ozone/tree/runner-latest Can you please create a new PR in that repository (with the same jira id) with adding the new path to this line: I will commit it + tag it --> It will create a new apache/ozone-runner image which can be used by updating |
|
Wow, thanks @elek for the comment. |
|
New ozone-runner is available: And (hopefully) the acceptance tests will be passed and ready to merge. |
elek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 thanks the update
Tested locally and worked well. The acceptance tests failures are independent (only a few of them are failing because the security problem which is already fixed on master.)
|
Thanks @elek for all the help and reviews. |
What changes were proposed in this pull request?
Relocate the docker scripts in dist.
(from
bin/docker/tolibexec/)What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-1701
How was this patch tested?
Ran
test-all.shunder$OZONE_HOME/compose/in distribution.