Skip to content

Conversation

@cxorm
Copy link
Member

@cxorm cxorm commented Oct 24, 2019

What changes were proposed in this pull request?

Relocate the docker scripts in dist.
(from bin/docker/ to libexec/)

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-1701

How was this patch tested?

Ran test-all.sh under $OZONE_HOME/compose/ in distribution.

@cxorm
Copy link
Member Author

cxorm commented Oct 25, 2019

/retest

@cxorm
Copy link
Member Author

cxorm commented Oct 25, 2019

When test-all.sh is ran in distribution, it works well.
But when it called by acceptance.sh, it fails.
We are looking for the cause.

@elek
Copy link
Member

elek commented Oct 31, 2019

Seems to be working for me even with acceptance.sh. Let's try to retest.

@elek
Copy link
Member

elek commented Oct 31, 2019

/retest

@elek
Copy link
Member

elek commented Nov 4, 2019

No idea what's wrong here, but I am not brave enough to commit it without understanding the reason of the acceptance test failure.

Let me try to find the root cause...

@cxorm
Copy link
Member Author

cxorm commented Nov 4, 2019

No idea what's wrong here, but I am not brave enough to commit it without understanding the reason of the acceptance test failure.

Let me try to find the root cause...

Yes, thanks @elek for the review.
We're going to find the root cause.

@elek
Copy link
Member

elek commented Nov 4, 2019

Ok. I found the problem. The changed Dockerfile is used only to create images for k8s deployment.

To change the PATH in the ozone-runner image, a new PR should be created in hadoop-ozone-docker repository (ozone-runner branch):

https://github.com/apache/hadoop-docker-ozone/tree/runner-latest

Can you please create a new PR in that repository (with the same jira id) with adding the new path to this line:

https://github.com/apache/hadoop-docker-ozone/blob/7619b7b7d1cc27629292f959d082c01e23ae8870/Dockerfile#L39

I will commit it + tag it --> It will create a new apache/ozone-runner image which can be used by updating hadoop-ozone/dist/pom.xml (docker.ozone-runner.version)

@cxorm
Copy link
Member Author

cxorm commented Nov 4, 2019

Wow, thanks @elek for the comment.
This comment help me a lot.
Fixed and send a PR in apache/hadoop-docker-ozone.

@elek
Copy link
Member

elek commented Nov 7, 2019

New ozone-runner is available: apache/ozone-runner:20191107-1 You can update the version in hadoop-ozone/dist/pom.xml

<docker.ozone-runner.version>20191106-1</docker.ozone-runner.version>

And (hopefully) the acceptance tests will be passed and ready to merge.

Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks the update

Tested locally and worked well. The acceptance tests failures are independent (only a few of them are failing because the security problem which is already fixed on master.)

@elek elek closed this in 9ce2dd7 Nov 8, 2019
@cxorm
Copy link
Member Author

cxorm commented Nov 8, 2019

Thanks @elek for all the help and reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants