Skip to content

HDDS-12373. Use File.getUsableSpace() instead of File.getFreeSpace() to calcuate usedSpace in DedicatedDiskSpaceUsage #7927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChenSammi merged 2 commits into from
Mar 19, 2025
Merged

HDDS-12373. Use File.getUsableSpace() instead of File.getFreeSpace() to calcuate usedSpace in DedicatedDiskSpaceUsage #7927

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0151d7
HDDS-12473. Remove system reserved space from calculation
symious Mar 13, 2025
5b479d6
HDDS-12373. Revert capacity
symious Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/fs/DedicatedDiskSpaceUsage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public long getUsedSpace() {
* @return used space
*/
private long calculateUsedSpace() {
return getCapacity() - getFile().getFreeSpace();
return getCapacity() - getFile().getUsableSpace();
Copy link
Contributor

@adoroszlai adoroszlai Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: javadoc on calculateUsedSpace still mentions "free space". I guess we can update it in any patches touching this code, no need for a new PR just for this.

Also: getAvailble() also returns getUsableSpace(), so we could clarify the logic by changing to:

getCapacity() - getAvailable()

}

}