Skip to content

HDDS-10760. SCMExceptions resulting from admin CLI commands are treated as retriable. #7854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 3 commits into from
Feb 15, 2025
Merged

HDDS-10760. SCMExceptions resulting from admin CLI commands are treated as retriable. #7854

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c257f44
HDDS-10760. SCMExceptions resulting from admin CLI commands are treat…
aswinshakil Feb 12, 2025
8f58d90
HDDS-10760. Add constructors for other classes.
aswinshakil Feb 12, 2025
5a93a56
mention current class in javadoc, not parent
adoroszlai Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/BadDataLocationException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ public class BadDataLocationException extends IOException {
private final List<DatanodeDetails> failedLocations = new ArrayList<>();
private int failedLocationIndex;

/**
* Required for Unwrapping {@code RemoteException}. Used by
* {@link org.apache.hadoop.ipc.RemoteException#unwrapRemoteException()}
*/
public BadDataLocationException(String message) {
super(message);
}

public BadDataLocationException(DatanodeDetails dn) {
super();
failedLocations.add(dn);
Expand Down
10 changes: 10 additions & 0 deletions ...op-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,16 @@
*/
public class ContainerException extends SCMException {

/**
* Constructs an {@code SCMException} with {@code null}
Comment thread
adoroszlai marked this conversation as resolved.
Outdated
* as its result code. <p>
* Required for Unwrapping {@code RemoteException}. Used by
* {@link org.apache.hadoop.ipc.RemoteException#unwrapRemoteException()}
*/
public ContainerException(String message) {
super(message);
}

/**
* Constructs an {@code ContainerException} with {@code null}
* as its error detail message.
Expand Down
11 changes: 11 additions & 0 deletions hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/exceptions/SCMException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@
public class SCMException extends IOException {
private final ResultCodes result;

/**
* Constructs an {@code IOException} with {@code null}
Comment thread
adoroszlai marked this conversation as resolved.
Outdated
* as its result code. <p>
* Required for Unwrapping {@code RemoteException}. Used by
* {@link org.apache.hadoop.ipc.RemoteException#unwrapRemoteException()}
*/
public SCMException(String message) {
super(message);
this.result = null;
}

/**
* Constructs an {@code IOException} with {@code null}
* as its error detail message.
Expand Down
9 changes: 9 additions & 0 deletions hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ha/NonRetriableException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,15 @@
*/
public class NonRetriableException extends IOException {

/**
* Constructs an {@code IOException} with the given detailed message. <p>
Comment thread
adoroszlai marked this conversation as resolved.
Outdated
* Required for Unwrapping {@code RemoteException}. Used by
* {@link org.apache.hadoop.ipc.RemoteException#unwrapRemoteException()}
*/
public NonRetriableException(String message) {
super(message);
}

public NonRetriableException(IOException exception) {
super(exception);
}
Expand Down
10 changes: 10 additions & 0 deletions ...scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/InsufficientDatanodesException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ public final class InsufficientDatanodesException extends IOException {
private final int required;
private final int available;

/**
* Required for Unwrapping {@code RemoteException}. Used by
* {@link org.apache.hadoop.ipc.RemoteException#unwrapRemoteException()}
*/
public InsufficientDatanodesException(String message) {
super(message);
this.required = 0;
this.available = 0;
}

public InsufficientDatanodesException(int required, int available,
String message) {
super(message);
Expand Down