Skip to content

Conversation

@ArafatKhan2198
Copy link
Contributor

@ArafatKhan2198 ArafatKhan2198 commented Jan 28, 2025

What changes were proposed in this pull request?

Parallel processing in Recon ContainerKeyMapperTask

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12097

How was this patch tested?

Manual Testing also existing UT's passed.

@ArafatKhan2198 ArafatKhan2198 marked this pull request as ready for review February 3, 2025 08:32
@ArafatKhan2198 ArafatKhan2198 marked this pull request as draft February 3, 2025 12:54
@errose28
Copy link
Contributor

errose28 commented Feb 4, 2025

How does Recon get the full path to the key for FSO? Currently it looks like it will only work on the key with parent IDs. I think we need something like HDDS-11777 for this.

truncateTable(this.containerKeyCountTable);

long truncateDuration = Duration.between(truncateStart, Instant.now()).toMillis();
LOG.info("Table truncation completed in {} ms", truncateDuration);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should ideally be a metric.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems test log to capture time taken for a part of operation, may not need this, can have overall operation time taken.

@ArafatKhan2198 ArafatKhan2198 marked this pull request as ready for review February 11, 2025 08:40
@adoroszlai adoroszlai marked this pull request as draft February 18, 2025 10:56
@adoroszlai
Copy link
Contributor

Superseded by #8002

@adoroszlai adoroszlai closed this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants