HDDS-3178. Add unit tests for OMGetDelegationToken Request and Response #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@hanishakoneru since you created the task for this change, may I ask you to review? |
Contributor
hanishakoneru
left a comment
hanishakoneru
left a comment
There was a problem hiding this comment.
Thank you @cxorm for working on this. Overall LGTM. Just a minor comment.
@bharatviswa504 do you wanna take a quick look as you worked on the DelegationTokenRequests?
Contributor
There was a problem hiding this comment.
Do we need to set the secretManager again? OzoneManager.getDelegationTokenMgr is going to return the same object again.
Member
Author
There was a problem hiding this comment.
Thank you @hanishakoneru for the review.
Yes, we don't need secretManager here.
Updated.
cxorm
force-pushed
the
HDDS-3178
branch
2 times, most recently
from
816fceb to
f7b5341
Compare
Contributor
|
LGTM. +1 pending CI. |
Member
Author
|
Rebase latest master-branch(#839) and trigger github-actions. |
Contributor
|
Thanks @cxorm for working on this. I will merge this PR. |
Member
Author
|
Thanks @hanishakoneru for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Proposed change.
Part for testing
OMGetDelegationTokenRequestIn
OMGetDelegationTokenRequest#preExecute, if theToken<OzoneTokenIdentifier> tokenis notnull, we setUpdateGetDelegationTokenRequestwithrenewIntervaland we setGetDelegationTokenResponsewith response. So the UT test these items.If the
Token<OzoneTokenIdentifier> tokenisnull, we do not setGetDelegationTokenResponsewith response and UT verified it.In
OMGetDelegationTokenRequest#validateAndUpdateCache, if the token is notnull, we will getOMClientResponsewith non "-1" renewTime and UT verified it.The UT also tests
validateAndUpdateCachewithToken<OzoneTokenIdentifier>that causes Exception.Part for testing
OMGetDelegationTokenResponseThe UT in this part tests functionality of
addToDBBatch.Create base classes
TestOMDelegationTokenResponseandTestOMDelegationTokenRequestfor later used bycancelTokenandrenewToken.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3178
How was this patch tested?
Add UTs including
TestOMGetDelegationTokenRequestTestOMGetDelegationTokenResponse