Skip to content

HDDS-12065. Checkpoint directory should be cleared on startup #7681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hemantk-12 merged 4 commits into from
Feb 24, 2025
Merged

HDDS-12065. Checkpoint directory should be cleared on startup #7681

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00e354c
HDDS-12065. Checkpoint directory should be cleared on startup
swamirishi Jan 10, 2025
31c9fea
Merge remote-tracking branch 'apache/master' into HEAD
swamirishi Jan 16, 2025
150c4af
Changed it to use Appache common's FileUtils.cleanDirectory()
hemantk-12 Feb 20, 2025
9f5af15
Log the exception and changed the expcetion message.
hemantk-12 Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,12 @@
import java.io.File;
import java.io.IOException;
import java.io.OutputStream;
import java.nio.file.FileVisitResult;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.nio.file.SimpleFileVisitor;
import java.nio.file.attribute.BasicFileAttributes;
import java.time.Duration;
import java.time.Instant;
import java.util.ArrayList;
Expand Down Expand Up @@ -107,6 +110,13 @@ public void initialize(DBStore store, DBCheckpointMetrics metrics,
}
bootstrapTempData = Paths.get(tempData,
"temp-bootstrap-data").toFile();
if (bootstrapTempData.exists()) {
try {
deleteContents(bootstrapTempData.toPath());
} catch (IOException e) {
throw new ServletException(e);
}
}
if (!bootstrapTempData.exists() &&
!bootstrapTempData.mkdirs()) {
throw new ServletException("Failed to make:" + bootstrapTempData);
Expand All @@ -123,6 +133,24 @@ private boolean hasPermission(UserGroupInformation user) {
}
}

private void deleteContents(Path directory) throws IOException {
Files.walkFileTree(directory, new SimpleFileVisitor<Path>() {
@Override
public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IOException {
Files.delete(file); // Delete file
return FileVisitResult.CONTINUE;
}

@Override
public FileVisitResult postVisitDirectory(Path dir, IOException exc) throws IOException {
if (!dir.equals(directory)) { // Skip deleting the root directory
Files.delete(dir);
}
return FileVisitResult.CONTINUE;
}
});
}

/**
* Generates Snapshot checkpoint as tar ball.
* @param request the HTTP servlet request
Expand Down
Loading