HDDS-12034. Enable sortpom in hadoop-hdds-interface server, admin & client #7660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
approved these changes
Jan 8, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @nandakumar131 for the patch.
Comment on lines
-149
to
-151
| <replace token="com.google.protobuf" | ||
| value="org.apache.ratis.thirdparty.com.google.protobuf" | ||
| dir="target/generated-sources/java/org/apache/hadoop/hdds/protocol/datanode/proto"> |
Contributor
There was a problem hiding this comment.
I find the original format more readable, but the option in sortpom to preserve this (indentAttribute) is available only in newer versions that do not support Java 8.
Contributor
Author
There was a problem hiding this comment.
Me too. The original format was easy to read.
Let's revisit this once we move to the newer version.
Contributor
Author
|
Thanks @adoroszlai for the review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable sortpom in hadoop-hdds-interface server, admin & client
Sortpom plugin was added as part of #7555.
This PR enables the plugin for hadoop-hdds sub-modules. (part 5)
Sorting all the sub-modules under hadoop-hdds creates a big change, which will be hard to review. So, breaking this into multiple PRs.
This PR sorts pom of the following sub-modules.
What is the link to the Apache JIRA
HDDS-12034
How was this patch tested?
Manually tested by adding out of order property.
hadoop-hdds/interface-server/pom.xmlhadoop-hdds/interface-admin/pom.xmlhadoop-hdds/interface-client/pom.xml