HDDS-12020. Enable sortpom in hdds-erasurecode, hdds-framework, hdds-hadoop-dependency-client. #7644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hadoop-dependency-client.
adoroszlai
reviewed
Jan 5, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @nandakumar131 for the patch. Mostly LGTM, two minor comments about comments. :)
Comment on lines
+42
to
47
| <groupId>org.apache.ozone</groupId> | ||
| <artifactId>hdds-config</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
| <!-- Test dependencies --> |
Contributor
There was a problem hiding this comment.
We can either remove <!-- Test dependencies -->, or move it before the first one with test scope.
Contributor
Author
There was a problem hiding this comment.
My bad, I will fix (move it where the test dependencies start) this in the next PR.
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-lang3</artifactId> | ||
| </exclusion> | ||
| <!-- commons-cli is required by OzoneFsShell --> |
Contributor
There was a problem hiding this comment.
Let's move this comment to between commons-beanutils and commons-codec (where commons-cli exclusion would fit).
Contributor
Author
|
Thanks for the review and merge @adoroszlai. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable sortpom in hdds-erasurecode, hdds-framework, hdds-hadoop-dependency-client
Sortpom plugin was added as part of #7555.
This PR enables the plugin for hadoop-hdds sub-modules. (part 3)
Sorting all the sub-modules under hadoop-hdds creates a big change, which will be hard to review. So, breaking this into multiple PRs.
This PR sorts pom of the following sub-modules.
What is the link to the Apache JIRA
HDDS-12020
How was this patch tested?
Manually tested by adding out of order property.
hadoop-hdds/erasurecode/pom.xmlhadoop-hdds/framework/pom.xmlhadoop-hdds/hadoop-dependency-client/pom.xml