HDDS-11997. Duplicate snapshot purge request causes NPE #7627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I01c48efb77754672bdae9aa937bcffc8a0b896cf
Contributor
Author
|
Thanks for reviewing the pr @sumitagrawl . @hemantk-12 @aswinshakil if you have any review comments on the patch I can address them with a follow up patch |
ptlrs
pushed a commit
to ptlrs/ozone
that referenced
this pull request
Mar 8, 2025
…pache#7627) (apache#190) * CDPD-77427. HDDS-11997. Duplicate snapshot purge request causes NPE (apache#7627) (cherry picked from commit ad108c8) Change-Id: I02dae0a1994bafa6dc95bd2a9a38ecb82ac45a07 * CDPD-76953. HDDS-11893. Fix full snapshot diff fallback logic because of DAG pruning (apache#7549) (cherry picked from commit 853d657) Change-Id: Idbdcb724c2b2da23614c2be6a4e2a88f7a4f5a71 (cherry picked from commit 4cff8f827a9cfc810f48c1be767963dad428f1c5) * CDPD-77091. HDDS-11908. Snapshot diff DAG traversal should not skip node based on prefix presence (apache#7567) (cherry picked from commit 66ccc25) Change-Id: Id1960cfadc9a983c89b379ccb87a4fa6d2586203 (cherry picked from commit b10b7b0d0a1b4c7fc3d0bbeda457a8ff0a0e2313) * CDPD-77085. HDDS-11914. Snapshot diff should not filter SST Files based by reading SST file reader (apache#7563) (cherry picked from commit 7a46080) Change-Id: I7788f8b962985c12ba2cec9b8cab537a392a5b65 (cherry picked from commit b8601fe948a993632f8028a8947ee53dde6e4a5e) * CDPD-67962. HDDS-10562. Fix infinite loop in ozone fs -ls /volume (apache#6416) (cherry picked from commit 4ca8edb) Change-Id: I015f524950ebf15491bcd8136caa11deea60027a (cherry picked from commit 206353c44479761c6d416704c1b01aebd66b9922) * CDPD-77818. HDDS-12064. Optimize bootstrap logic to reduce loop while checking file links (apache#7676) Change-Id: Ibee016b338abdbb0bee6e62af89cc2560fb8f350 --------- Co-authored-by: Swaminathan Balachandran <[email protected]> Co-authored-by: Swaminathan Balachandran <[email protected]> Co-authored-by: Symious <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Duplicate snapshot purge request causes NPE.
The fix would be add a check if the snapshotInfo is not null before adding to updatedSnapshotInfos map.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11997
How was this patch tested?
Added a unit test for duplicate snapshot purge request which repros the issue