-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-9791. Add tests for Datanodes page #7626
Conversation
Hi @ivandika3 @devmadhuu @ArafatKhan2198 could you help take a look at this PR? |
Thanks for the effort on this @devabhishekpal From the looks of it The existing patch successfully tests table rendering, data loading on page mount, row selection, search filtering, API error handling, static and empty API responses, edge cases for search results, data display in rows, and integration with mock servers. The tests are missing coverage for features like:
Let me know if we are planning to integrate them in this scope. |
...main/resources/webapps/recon/ozone-recon-web/src/__tests__/datanodes/DatanodesTable.test.tsx
Show resolved
Hide resolved
.../src/main/resources/webapps/recon/ozone-recon-web/src/__tests__/datanodes/Datanodes.test.tsx
Outdated
Show resolved
Hide resolved
@devabhishekpal Could you also test out this scenario as well :- Search input edge cases (e.g., special characters, case sensitivity). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the patch @devabhishekpal
LGTM +1
|
Thanks for the patch @devabhishekpal |
What changes were proposed in this pull request?
HDDS-9791. Add tests for Datanodes page
Please describe your PR in detail:
@testing-library/user-event
to help with triggering various UI events like clicks, change, type etc.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9791
How was this patch tested?
Patch was tested manually by running all the tests including previous Overview page tests