-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-11902. Remove upgrade tests for non-ha and om-ha #7610
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chiacyu for the patch, LGTM.
Please use commit message in the format HDDS-11902. Remove upgrade tests for non-ha and om-ha
(same as PR title). If PR has a single commit, GitHub uses the commit's message by default, not the PR title. Sometimes committers forget to update the message when merging (example: 16322fd). I pushed an empty commit to force GitHub to use the PR title when merging this.
CI passed for the original commit, so this can be merged without triggering again.
@adoroszlai , thanks for the reminder, I didn't realize that at the first place. I would keep it in mind to the following pull requests. much appreciated! |
Thanks @chiacyu for the patch. Overall looks good, just some nits.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Removing om-ha compose files because it doesn't have SCM HA. (ozone-ha include both OM HA and SCM HA so we want to keep that)
What changes were proposed in this pull request?
Some of the files are depreciated and can be removed and also the related docs and comments.
non-ha
andom-ha
from compose.manual-upgrade
from upgrades.What is the link to the Apache JIRA
Please check HDDS-11902 for more details, thanks.
How was this patch tested?
It can be tested by CI.