Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11902. Remove upgrade tests for non-ha and om-ha #7610

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chiacyu
Copy link
Contributor

@chiacyu chiacyu commented Dec 22, 2024

What changes were proposed in this pull request?

Some of the files are depreciated and can be removed and also the related docs and comments.

  • non-ha and om-ha from compose.
  • manual-upgrade from upgrades.

What is the link to the Apache JIRA

Please check HDDS-11902 for more details, thanks.

How was this patch tested?

It can be tested by CI.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chiacyu for the patch, LGTM.

Please use commit message in the format HDDS-11902. Remove upgrade tests for non-ha and om-ha (same as PR title). If PR has a single commit, GitHub uses the commit's message by default, not the PR title. Sometimes committers forget to update the message when merging (example: 16322fd). I pushed an empty commit to force GitHub to use the PR title when merging this.

CI passed for the original commit, so this can be merged without triggering again.

@adoroszlai adoroszlai requested a review from errose28 December 22, 2024 10:36
@chiacyu
Copy link
Contributor Author

chiacyu commented Dec 22, 2024

@adoroszlai , thanks for the reminder, I didn't realize that at the first place. I would keep it in mind to the following pull requests. much appreciated!

@chungen0126
Copy link
Contributor

Thanks @chiacyu for the patch. Overall looks good, just some nits.
Something could also be remove in the following lines, since that Manual upgrade is removed.

Non-rolling upgrades and downgrades are supported from 1.1.0 to any later version. Note that 1.1.0 did not have the non-rolling upgrade framework, so things like preparing the OMs for upgrade and checking finalization status are not present in that version. Manual upgrade is the only supported upgrade option from 1.0.0 to 1.1.0.

Manual upgrade is the only supported upgrade option from 1.0.0 to 1.1.0.

Docker compose cluster definitions to be used in upgrade testing are defined in the *compose* directory. A compose cluster can be selected by specifying the name of its subdirectory as the first argument to `run_test`. `run_test` will then source the `load.sh` script in the cluster's directory so it is used during the test. For manual testing, docker compose can be used normally from the compose cluster directory. Note that some clusters may not work with older versions. Ozone 1.1.0, for example, does not support SCM HA.

For manual testing, docker compose can be used normally from the compose cluster directory. Note that some clusters may not work with older versions. Ozone 1.1.0, for example, does not support SCM HA.

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Removing om-ha compose files because it doesn't have SCM HA. (ozone-ha include both OM HA and SCM HA so we want to keep that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants