Skip to content

HDDS-11770. Change default failed volume tolerated to 0 #7499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChenSammi wants to merge 1 commit into from
Closed

HDDS-11770. Change default failed volume tolerated to 0 #7499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions ...ain/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public class DatanodeConfiguration extends ReconfigurableConfig {

static final long PERIODIC_DISK_CHECK_INTERVAL_MINUTES_DEFAULT = 60;

static final int FAILED_VOLUMES_TOLERATED_DEFAULT = -1;
static final int FAILED_VOLUMES_TOLERATED_DEFAULT = 0;

public static final int DISK_CHECK_IO_TEST_COUNT_DEFAULT = 3;

Expand Down Expand Up @@ -330,35 +330,38 @@ public void setBlockDeletionLimit(int limit) {
PERIODIC_DISK_CHECK_INTERVAL_MINUTES_DEFAULT;

@Config(key = "failed.data.volumes.tolerated",
defaultValue = "-1",
defaultValue = "0",
type = ConfigType.INT,
tags = { DATANODE },
description = "The number of data volumes that are allowed to fail "
+ "before a datanode stops offering service. "
+ "Config this to -1 means unlimited, but we should have "
+ "at least one good volume left."
+ "before a datanode stops offering service. By default, "
+ "any volume failure will cause a datanode to shutdown. "
+ "The value should be greater than or equal to -1 , -1 represents minimum "
+ "1 valid volume."
)
private int failedDataVolumesTolerated = FAILED_VOLUMES_TOLERATED_DEFAULT;

@Config(key = "failed.metadata.volumes.tolerated",
defaultValue = "-1",
defaultValue = "0",
type = ConfigType.INT,
tags = { DATANODE },
description = "The number of metadata volumes that are allowed to fail "
+ "before a datanode stops offering service. "
+ "Config this to -1 means unlimited, but we should have "
+ "at least one good volume left."
+ "before a datanode stops offering service. By default, "
+ "any volume failure will cause a datanode to shutdown. "
+ "The value should be greater than or equal to -1 , -1 represents minimum "
+ "1 valid volume."
)
private int failedMetadataVolumesTolerated = FAILED_VOLUMES_TOLERATED_DEFAULT;

@Config(key = "failed.db.volumes.tolerated",
defaultValue = "-1",
defaultValue = "0",
type = ConfigType.INT,
tags = { DATANODE },
description = "The number of db volumes that are allowed to fail "
+ "before a datanode stops offering service. "
+ "Config this to -1 means unlimited, but we should have "
+ "at least one good volume left."
+ "before a datanode stops offering service. By default, "
+ "any volume failure will cause a datanode to shutdown. "
+ "The value should be greater than or equal to -1 , -1 represents minimum "
+ "1 valid volume."
)
private int failedDbVolumesTolerated = FAILED_VOLUMES_TOLERATED_DEFAULT;

Expand Down
6 changes: 4 additions & 2 deletions hadoop-hdds/docs/content/feature/dn-merge-rocksdb.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,11 @@ For some advanced cluster admins who have the high performance requirement, he/s
</property>
<property>
<name>hdds.datanode.failed.db.volumes.tolerated</name>
<value>-1</value>
<value>0</value>
<description>The number of db volumes that are allowed to fail before a datanode stops offering service.
Default -1 means unlimited, but we should have at least one good volume left.</description>
By default, any volume failure will cause a datanode to shutdown.
The value should be greater than or equal to -1 , -1 represents minimum 1 valid volume.
</description>
</property>
```

Expand Down
6 changes: 4 additions & 2 deletions hadoop-hdds/docs/content/feature/dn-merge-rocksdb.zh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,11 @@ summary: Ozone DataNode Container模式简介V3
</property>
<property>
<name>hdds.datanode.failed.db.volumes.tolerated</name>
<value>-1</value>
<value>0</value>
<description>The number of db volumes that are allowed to fail before a datanode stops offering service.
Default -1 means unlimited, but we should have at least one good volume left.</description>
By default, any volume failure will cause a datanode to shutdown.
The value should be greater than or equal to -1 , -1 represents minimum 1 valid volume.
</description>
</property>
```

Expand Down