Skip to content

HDDS-11755. mktemp --suffix does not work on Mac #7457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 1 commit into from
Nov 20, 2024
Merged

HDDS-11755. mktemp --suffix does not work on Mac #7457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hadoop-ozone/dist/src/main/compose/testlib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ run_rebot() {

shift 2

local tempdir="$(mktemp -d --suffix rebot -p "${output_dir}")"
local tempdir="$(mktemp -d "${output_dir}"/rebot-XXXXXX)"
Copy link
Contributor

@sodonnel sodonnel Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the rebot-XXXXXX part? Is XXXXX a placeholder or is that the actual filename?

Copy link
Contributor Author

@adoroszlai adoroszlai Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a placeholder updated with random characters for each call.

#Should be writeable from the docker containers where user is different.
chmod a+wx "${tempdir}"
if docker run --rm -v "${input_dir}":/rebot-input -v "${tempdir}":/rebot-output -w /rebot-input \
Expand Down