Skip to content

HDDS-11386. Multithreading bug in ContainerBalancerTask #7339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sumitagrawl merged 6 commits into from
Nov 25, 2024
Merged

HDDS-11386. Multithreading bug in ContainerBalancerTask #7339

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3008272
HDDS-11386. Multithreading bug in ContainerBalancerTask
sarvekshayr Oct 7, 2024
523e391
Fixed checkstyle error
sarvekshayr Oct 7, 2024
c88f8ea
HDDS-11386. Multithreading bug in ContainerBalancerTask
sarvekshayr Oct 21, 2024
36b7112
Added locks and ConcurrentLinkedQueue to iterationsStatistic
sarvekshayr Nov 15, 2024
8b3ff5e
Replaced Map with ConcurrentHashMap
sarvekshayr Nov 20, 2024
4e3ea5b
Use ConcurrentHashMap instead of HashMap and calc last iteration base…
sarvekshayr Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 42 additions & 40 deletions ...cm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public class ContainerBalancerTask implements Runnable {
private IterationResult iterationResult;
private int nextIterationIndex;
private boolean delayStart;
private List<ContainerBalancerTaskIterationStatusInfo> iterationsStatistic;
private final List<ContainerBalancerTaskIterationStatusInfo> iterationsStatistic;

/**
* Constructs ContainerBalancerTask with the specified arguments.
Expand Down Expand Up @@ -344,45 +344,47 @@ private void saveIterationStatistic(Integer iterationNumber, IterationResult iR)

public List<ContainerBalancerTaskIterationStatusInfo> getCurrentIterationsStatistic() {

int lastIterationNumber = iterationsStatistic.stream()
.mapToInt(ContainerBalancerTaskIterationStatusInfo::getIterationNumber)
.max()
.orElse(0);

ContainerBalancerTaskIterationStatusInfo currentIterationStatistic = new ContainerBalancerTaskIterationStatusInfo(
lastIterationNumber + 1,
null,
getSizeScheduledForMoveInLatestIteration() / OzoneConsts.GB,
sizeActuallyMovedInLatestIteration / OzoneConsts.GB,
metrics.getNumContainerMovesScheduledInLatestIteration(),
metrics.getNumContainerMovesCompletedInLatestIteration(),
metrics.getNumContainerMovesFailedInLatestIteration(),
metrics.getNumContainerMovesTimeoutInLatestIteration(),
findTargetStrategy.getSizeEnteringNodes()
.entrySet()
.stream()
.filter(Objects::nonNull)
.filter(datanodeDetailsLongEntry -> datanodeDetailsLongEntry.getValue() > 0)
.collect(Collectors.toMap(
entry -> entry.getKey().getUuid(),
entry -> entry.getValue() / OzoneConsts.GB
)
),
findSourceStrategy.getSizeLeavingNodes()
.entrySet()
.stream()
.filter(Objects::nonNull)
.filter(datanodeDetailsLongEntry -> datanodeDetailsLongEntry.getValue() > 0)
.collect(
Collectors.toMap(
entry -> entry.getKey().getUuid(),
entry -> entry.getValue() / OzoneConsts.GB
)
)
);
List<ContainerBalancerTaskIterationStatusInfo> resultList = new ArrayList<>(iterationsStatistic);
resultList.add(currentIterationStatistic);
return resultList;
synchronized (iterationsStatistic) {
int lastIterationNumber = iterationsStatistic.stream()
.mapToInt(ContainerBalancerTaskIterationStatusInfo::getIterationNumber)
.max()
.orElse(0);

ContainerBalancerTaskIterationStatusInfo currentIterationStatistic = new ContainerBalancerTaskIterationStatusInfo(
lastIterationNumber + 1,
null,
getSizeScheduledForMoveInLatestIteration() / OzoneConsts.GB,
sizeActuallyMovedInLatestIteration / OzoneConsts.GB,
metrics.getNumContainerMovesScheduledInLatestIteration(),
metrics.getNumContainerMovesCompletedInLatestIteration(),
metrics.getNumContainerMovesFailedInLatestIteration(),
metrics.getNumContainerMovesTimeoutInLatestIteration(),
new ConcurrentHashMap<>(findTargetStrategy.getSizeEnteringNodes())
.entrySet()
.stream()
.filter(Objects::nonNull)
.filter(datanodeDetailsLongEntry -> datanodeDetailsLongEntry.getValue() > 0)
.collect(Collectors.toMap(
entry -> entry.getKey().getUuid(),
entry -> entry.getValue() / OzoneConsts.GB
)
),
new ConcurrentHashMap<>(findSourceStrategy.getSizeLeavingNodes())
.entrySet()
.stream()
.filter(Objects::nonNull)
.filter(datanodeDetailsLongEntry -> datanodeDetailsLongEntry.getValue() > 0)
.collect(
Collectors.toMap(
entry -> entry.getKey().getUuid(),
entry -> entry.getValue() / OzoneConsts.GB
)
)
);
List<ContainerBalancerTaskIterationStatusInfo> resultList = new ArrayList<>(iterationsStatistic);
resultList.add(currentIterationStatistic);
return resultList;
}
}

/**
Expand Down