Skip to content

HDDS-11518. Recon OmDB Insights show isKey=true for directories #7260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devmadhuu merged 2 commits into from
Oct 3, 2024
Merged

HDDS-11518. Recon OmDB Insights show isKey=true for directories #7260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09bfba3
HDDS-11518. [Ozone][Om DBinsights] iskey Metadata info is hardcoded t…
ArafatKhan2198 Oct 1, 2024
594bfc9
Fixed checkstyle issues
ArafatKhan2198 Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/OMDBInsightEndpoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ public Response getOpenKeyInfo(
continue;
}
KeyEntityInfo keyEntityInfo = new KeyEntityInfo();
keyEntityInfo.setIsKey(omKeyInfo.isFile());
keyEntityInfo.setKey(key);
keyEntityInfo.setPath(omKeyInfo.getKeyName());
keyEntityInfo.setInStateSince(omKeyInfo.getCreationTime());
Expand Down Expand Up @@ -549,6 +550,7 @@ private void getPendingForDeletionDirInfo(
continue;
}
KeyEntityInfo keyEntityInfo = new KeyEntityInfo();
keyEntityInfo.setIsKey(omKeyInfo.isFile());
keyEntityInfo.setKey(omKeyInfo.getFileName());
keyEntityInfo.setPath(createPath(omKeyInfo));
keyEntityInfo.setInStateSince(omKeyInfo.getCreationTime());
Expand Down Expand Up @@ -1257,6 +1259,7 @@ private KeyEntityInfo createKeyEntityInfoFromOmKeyInfo(String dbKey,
OmKeyInfo keyInfo) throws IOException {
KeyEntityInfo keyEntityInfo = new KeyEntityInfo();
keyEntityInfo.setKey(dbKey); // Set the DB key
keyEntityInfo.setIsKey(keyInfo.isFile());
keyEntityInfo.setPath(ReconUtils.constructFullPath(keyInfo, reconNamespaceSummaryManager,
omMetadataManager));
keyEntityInfo.setSize(keyInfo.getDataSize());
Expand Down
1 change: 1 addition & 0 deletions ...zone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/OMDBInsightSearchEndpoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,7 @@ private KeyEntityInfo createKeyEntityInfoFromOmKeyInfo(String dbKey,
OmKeyInfo keyInfo) {
KeyEntityInfo keyEntityInfo = new KeyEntityInfo();
keyEntityInfo.setKey(dbKey); // Set the DB key
keyEntityInfo.setIsKey(keyInfo.isFile());
keyEntityInfo.setPath(keyInfo.getKeyName()); // Assuming path is the same as key name
keyEntityInfo.setInStateSince(keyInfo.getCreationTime());
keyEntityInfo.setSize(keyInfo.getDataSize());
Expand Down
4 changes: 2 additions & 2 deletions hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/KeyEntityInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ public boolean isKey() {
return isKey;
}

public void setKey(boolean key) {
isKey = key;
public void setIsKey(boolean isKey) {
this.isKey = isKey;
}
}