-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-11408. Snapshot rename table entries are propagated incorrectly on snapshot deletes #7200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
0335ed2
HDDS-11408. Snapshot rename table entries are propogated incorrectly …
swamirishi 53a5b5d
HDDS-11408. Add test cases
swamirishi 87ea520
HDDS-11408. Address review comments
swamirishi 6675538
HDDS-11408. Address review comments
swamirishi 96c3daa
HDDS-11408. Address review comments
swamirishi 535a6cd
HDDS-11408. Address review comments
swamirishi 7d49b64
HDDS-11408. Address review comments
swamirishi f79c5c7
HDDS-11408. Address review comments
swamirishi 7124b1e
HDDS-11408. Address review comments
swamirishi ae0085c
HDDS-11408. Add test cases
swamirishi 5fb5d8c
HDDS-11408. Add test cases
swamirishi 67b5a05
HDDS-11408. Add race condition test case
swamirishi 4b724fe
HDDS-11408. fix findbugs
swamirishi e2f0461
HDDS-11408. Address review comments
swamirishi 8600803
HDDS-11408. Address review comments
swamirishi 8b477b6
HDDS-11408. Address review comments
swamirishi 09b9523
HDDS-11408. Address review comments
swamirishi 7ee74dd
HDDS-11408. Address review comments
swamirishi da7701f
HDDS-11408. Address review comments
swamirishi b7380e1
HDDS-11408. Address review comments
swamirishi e31c153
HDDS-11408. Address review comments
swamirishi f6104fd
HDDS-11408. Address review comments
swamirishi bc4de22
HDDS-11408. Address review comments
swamirishi 57d665a
HDDS-11408. Address review comments
swamirishi 075441b
HDDS-11408. Address review comments
swamirishi c3a11a5
HDDS-11408. Address review comments
swamirishi bd28a4c
HDDS-11408. Address review comments
swamirishi 1fd5f1d
HDDS-11408. Address review comments
swamirishi d1c0a77
HDDS-11408. Debug test failure
swamirishi 0d0e3e7
HDDS-11408. Debug test failure
swamirishi 554e452
HDDS-11408. Debug test failure
swamirishi 1aa55ff
HDDS-11408. Debug test failure
swamirishi 364663c
HDDS-11408. Debug test failure
swamirishi 9af1e99
HDDS-11408. Add log
swamirishi 0a8183d
HDDS-11408. Add log
swamirishi 73572ad
HDDS-11408. Add log
swamirishi 063f7b7
HDDS-11408. Address review comments
swamirishi 302491d
HDDS-11408. Address review comments
swamirishi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qq: Is this for testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swamirishi , This seems incorrect. Filed HDDS-13235
BTW, testing code should reside in tests. Otherwise, it may introduce real bugs to production code.