Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
0335ed2
HDDS-11408. Snapshot rename table entries are propogated incorrectly …
swamirishi Sep 13, 2024
53a5b5d
HDDS-11408. Add test cases
swamirishi Sep 16, 2024
87ea520
HDDS-11408. Address review comments
swamirishi Sep 16, 2024
6675538
HDDS-11408. Address review comments
swamirishi Sep 16, 2024
96c3daa
HDDS-11408. Address review comments
swamirishi Sep 16, 2024
535a6cd
HDDS-11408. Address review comments
swamirishi Sep 16, 2024
7d49b64
HDDS-11408. Address review comments
swamirishi Sep 17, 2024
f79c5c7
HDDS-11408. Address review comments
swamirishi Sep 17, 2024
7124b1e
HDDS-11408. Address review comments
swamirishi Sep 17, 2024
ae0085c
HDDS-11408. Add test cases
swamirishi Sep 17, 2024
5fb5d8c
HDDS-11408. Add test cases
swamirishi Sep 17, 2024
67b5a05
HDDS-11408. Add race condition test case
swamirishi Sep 18, 2024
4b724fe
HDDS-11408. fix findbugs
swamirishi Sep 18, 2024
e2f0461
HDDS-11408. Address review comments
swamirishi Sep 18, 2024
8600803
HDDS-11408. Address review comments
swamirishi Sep 18, 2024
8b477b6
HDDS-11408. Address review comments
swamirishi Sep 18, 2024
09b9523
HDDS-11408. Address review comments
swamirishi Sep 18, 2024
7ee74dd
HDDS-11408. Address review comments
swamirishi Sep 18, 2024
da7701f
HDDS-11408. Address review comments
swamirishi Sep 18, 2024
b7380e1
HDDS-11408. Address review comments
swamirishi Sep 18, 2024
e31c153
HDDS-11408. Address review comments
swamirishi Sep 18, 2024
f6104fd
HDDS-11408. Address review comments
swamirishi Sep 18, 2024
bc4de22
HDDS-11408. Address review comments
swamirishi Sep 18, 2024
57d665a
HDDS-11408. Address review comments
swamirishi Sep 18, 2024
075441b
HDDS-11408. Address review comments
swamirishi Sep 19, 2024
c3a11a5
HDDS-11408. Address review comments
swamirishi Sep 19, 2024
bd28a4c
HDDS-11408. Address review comments
swamirishi Sep 19, 2024
1fd5f1d
HDDS-11408. Address review comments
swamirishi Sep 19, 2024
d1c0a77
HDDS-11408. Debug test failure
swamirishi Sep 19, 2024
0d0e3e7
HDDS-11408. Debug test failure
swamirishi Sep 19, 2024
554e452
HDDS-11408. Debug test failure
swamirishi Sep 19, 2024
1aa55ff
HDDS-11408. Debug test failure
swamirishi Sep 19, 2024
364663c
HDDS-11408. Debug test failure
swamirishi Sep 19, 2024
9af1e99
HDDS-11408. Add log
swamirishi Sep 19, 2024
0a8183d
HDDS-11408. Add log
swamirishi Sep 19, 2024
73572ad
HDDS-11408. Add log
swamirishi Sep 19, 2024
063f7b7
HDDS-11408. Address review comments
swamirishi Sep 19, 2024
302491d
HDDS-11408. Address review comments
swamirishi Sep 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.Objects;

import org.apache.commons.lang3.NotImplementedException;
import org.apache.hadoop.hdds.annotation.InterfaceStability;
Expand Down Expand Up @@ -354,7 +355,27 @@ public V getValue() {
public String toString() {
return "(key=" + key + ", value=" + value + ")";
}

@Override
public boolean equals(Object obj) {
if (!(obj instanceof KeyValue)) {
return false;
}
KeyValue<?, ?> kv = (KeyValue<?, ?>) obj;
try {
return getKey().equals(kv.getKey()) && getValue().equals(kv.getValue());
} catch (IOException e) {
throw new RuntimeException(e);
}
}

@Override
public int hashCode() {
return Objects.hash(getKey(), getValue());
}
Comment on lines +359 to +375
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: Is this for testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swamirishi , This seems incorrect. Filed HDDS-13235

BTW, testing code should reside in tests. Otherwise, it may introduce real bugs to production code.

};


}

/** A {@link TableIterator} to iterate {@link KeyValue}s. */
Expand Down
Loading