-
Notifications
You must be signed in to change notification settings - Fork 589
HDDS-3185 Construct a standalone ratis server for SCM. #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks to work on this @timmylicheng I am confused a little bit because this was the last message on the mailing list:
It's just not clear for me if the design is final and the implementation is started or still under discussion? |
|
@elek Hey Marton, So far the doc work is ongoing in parallel with prototyping. I will try to finalize the design doc and schedule a call with the community to include more guys. |
426d818 to
62d467a
Compare
|
+1 |
|
@timmylicheng Thanks the explain it. I will add your explanation to the next Community Meeting minutes. |
|
Speaking about the code in the patch: I would suggest to use the new config based annotation model for new code: https://cwiki.apache.org/confluence/display/HADOOP/Java-based+configuration+API (I know it's not used everywhere, therefore it's hard to notice this movement, and some features can be still missing, but new code seems to be a good opportunity to switch to the new API) |
@elek This new interface actually looks nice! I have a refactor plan for OM and SCM Ratis chain. I will try to leverage with it in the refactoring work. The current way to populate configs needs some changes. |
Contributed-by: Li Cheng <[email protected]>
Thanks a lot. I am fine if it's a long-term plan (and we may need improvements on the Configuration API side, too). This API just so hidden (yet) that am trying to make it more widely known... ;-) |
Contributed-by: Li Cheng <[email protected]>
Contributed-by: Li Cheng <[email protected]>
Contributed-by: Li Cheng <[email protected]>
Contributed-by: Li Cheng <[email protected]>
Contributed-by: Li Cheng <[email protected]>
Contributed-by: Li Cheng <[email protected]>
What changes were proposed in this pull request?
Standalone SCM RatisServer
(Please fill in changes proposed in this fix)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3185
(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
Please replace this section with the link to the Apache JIRA)
How was this patch tested?
UT
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)