Skip to content

HDDS-11458. Selective checks: trigger checkstyle for properties file changes #7196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 2 commits into from
Sep 25, 2024
Merged

HDDS-11458. Selective checks: trigger checkstyle for properties file changes #7196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a10ecf
HDDS-11458. Selective checks: trigger checkstyle for properties file …
adoroszlai Sep 13, 2024
db3882e
add test case
adoroszlai Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions dev-support/ci/selective_ci_checks.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,3 +429,15 @@ load bats-assert/load.bash
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}

@test "properties file in resources" {
run dev-support/ci/selective_ci_checks.sh 71b8bdd8becf72d6f7d4e7986895504b8259b3e5

assert_output -p 'basic-checks=["rat","checkstyle","native"]'
assert_output -p needs-build=false
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=false
}
1 change: 1 addition & 0 deletions dev-support/ci/selective_ci_checks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@ function check_needs_checkstyle() {
"^hadoop-hdds/dev-support/checkstyle"
"pom.xml"
"src/..../java"
"src/..../resources/.*\.properties"
)
local ignore_array=(
"^hadoop-ozone/dist"
Expand Down