Skip to content

HDDS-11448. Improve documentation in ContainerStateMachine #7183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kerneltime merged 1 commit into from
Sep 11, 2024
Merged

HDDS-11448. Improve documentation in ContainerStateMachine #7183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions ...rg/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ public ContainerStateMachine(HddsDatanodeService hddsDatanodeService, RaftGroupI
// cache with FIFO eviction, and if element not found, this needs
// to be obtained from disk for slow follower
stateMachineDataCache = new ResourceCache<>(
(index, data) -> ((ByteString)data).size(),
(index, data) -> data.size(),
pendingRequestsBytesLimit,
(p) -> {
if (p.wasEvicted()) {
Expand Down Expand Up @@ -704,9 +704,10 @@ private ExecutorService getChunkExecutor(WriteChunkRequestProto req) {
return chunkExecutors.get(i);
}

/*
* writeStateMachineData calls are not synchronized with each other
* and also with applyTransaction.
/**
* {@link #writeStateMachineData(ContainerCommandRequestProto, long, long, long)}
* calls are not synchronized with each other
* and also with {@link #applyTransaction(TransactionContext)}.
*/
@Override
public CompletableFuture<Message> write(LogEntryProto entry, TransactionContext trx) {
Expand Down Expand Up @@ -824,7 +825,7 @@ public CompletableFuture<Void> flush(long index) {
}

/**
* This method is used by the Leader to read state machine date for sending appendEntries to followers.
* This method is used by the Leader to read state machine data for sending appendEntries to followers.
* It will first get the data from {@link #stateMachineDataCache}.
* If the data is not in the cache, it will read from the file by dispatching a command
*
Expand Down Expand Up @@ -1197,7 +1198,7 @@ public void notifyGroupRemove() {
try {
containerController.markContainerForClose(cid);
containerController.quasiCloseContainer(cid,
"Ratis group removed");
"Ratis group removed. Group id: " + gid);
} catch (IOException e) {
LOG.debug("Failed to quasi-close container {}", cid);
}
Expand Down