Skip to content

HDDS-11392. ChecksumByteBufferImpl's static initializer fails with java 17+ #7135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fapifta merged 1 commit into from
Sep 1, 2024
Merged

HDDS-11392. ChecksumByteBufferImpl's static initializer fails with java 17+ #7135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/JavaUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,24 @@ public final class JavaUtils {
* is equal or greater than the parameter.
*
* @param version 8, 9, 10 etc.
* @return comparison with system property, always true for 8
* @return comparison with system property, always true for any int up to 8
*/
public static boolean isJavaVersionAtLeast(int version) {
return JAVA_SPEC_VER >= version;
}

/**
* Query to see if major version of Java specification of the system
* is equal or less than the parameter.
*
* @param version 8, 9, 10 etc.
* @return comparison with system property
*/
public static boolean isJavaVersionAtMost(int version) {
return JAVA_SPEC_VER <= version;
}


/**
* Private constructor.
*/
Expand Down
14 changes: 8 additions & 6 deletions hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/ChecksumByteBufferImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,14 @@ public class ChecksumByteBufferImpl implements ChecksumByteBuffer {

static {
Field f = null;
try {
f = ByteBuffer.class
.getDeclaredField("isReadOnly");
f.setAccessible(true);
} catch (NoSuchFieldException e) {
LOG.error("No isReadOnly field in ByteBuffer", e);
if (JavaUtils.isJavaVersionAtMost(8)) {
Copy link
Contributor

@adoroszlai adoroszlai Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically an else branch for isJavaVersionAtLeast(9). ;)

Copy link
Contributor Author

@fapifta fapifta Sep 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is, however it is much more explicit about what happens, that's why I chose this way.

try {
f = ByteBuffer.class
.getDeclaredField("isReadOnly");
f.setAccessible(true);
} catch (NoSuchFieldException e) {
LOG.error("No isReadOnly field in ByteBuffer", e);
}
}
IS_READY_ONLY_FIELD = f;

Expand Down