Skip to content

HDDS-11325. Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose #7099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jojochuang merged 2 commits into from
Aug 20, 2024
Merged

HDDS-11325. Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose #7099

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0414ab8
HDDS-11325. Intermittent failure in TestBlockOutputStreamWithFailures…
jojochuang Aug 20, 2024
7e418ca
Same
jojochuang Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...egration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,8 @@ void testWriteMoreThanMaxFlushSize(boolean flushDelay, boolean enablePiggybackin
assertInstanceOf(RatisBlockOutputStream.class,
keyOutputStream.getStreamEntries().get(0).getOutputStream());

assertEquals(4, blockOutputStream.getBufferPool().getSize());
assertThat(blockOutputStream.getBufferPool().getSize())
.isLessThanOrEqualTo(4);
// writtenDataLength as well flushedDataLength will be updated here
assertEquals(dataLength, blockOutputStream.getWrittenDataLength());

Expand Down Expand Up @@ -729,7 +730,8 @@ void testWriteMoreThanMaxFlushSize(boolean flushDelay, boolean enablePiggybackin
// Since the data in the buffer is already flushed, flush here will have
// no impact on the counters and data structures

assertEquals(4, blockOutputStream.getBufferPool().getSize());
assertThat(blockOutputStream.getBufferPool().getSize())
.isLessThanOrEqualTo(4);
assertEquals(dataLength, blockOutputStream.getWrittenDataLength());
// dataLength > MAX_FLUSH_SIZE
assertEquals(flushDelay ? MAX_FLUSH_SIZE : dataLength,
Expand Down