HDDS-11320. Update OM, SCM, Datanode conf for RATIS-2135. #7080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojochuang
approved these changes
Aug 16, 2024
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
LGTM. Thanks @szetszwo
jojochuang
reviewed
Aug 16, 2024
| RaftServerConfigKeys.Log.Appender.setBufferByteLimit(properties, SizeInBytes.valueOf(logAppenderBufferByteLimit)); | ||
|
|
||
| // setMessageSizeMax with a different logAppenderBufferByteLimit | ||
| Assertions.assertThrows(IllegalStateException.class, |
Contributor
There was a problem hiding this comment.
but this API does not throw exception.
Contributor
Author
There was a problem hiding this comment.
Oops, I need to update the test.
Contributor
|
LGTM Merging it. |
Contributor
Author
|
@jojochuang , thanks a lot for reviewing and merging this! |
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Sep 16, 2024
(cherry picked from commit 37273d1)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Sep 18, 2024
(cherry picked from commit 37273d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Due to a bug, RATIS-2135 requires
to be 1MB larger than
We must change the OM, SCM and Datanode conf accordingly.
What is the link to the Apache JIRA
HDDS-11320
How was this patch tested?
A new unit test.