Skip to content

HDDS-11272. Statistics some node status information #7025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivandika3 merged 4 commits into from
Aug 6, 2024
Merged

HDDS-11272. Statistics some node status information #7025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e3d089f
HDDS-11272. Statistics some node status information
jianghuazhu Aug 3, 2024
58ebd1b
Fix some checkstyle
jianghuazhu Aug 3, 2024
62ed692
Fix some javadoc
jianghuazhu Aug 5, 2024
5c4d446
Update NodeStateManager
jianghuazhu Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,19 @@ public int getHealthyVolumeCount() {
}
}

/**
* Returns count of failed volumes reported by the data node.
* @return count of failed volumes
*/
public int getFailedVolumeCount() {
try {
lock.readLock().lock();
return failedVolumeCount;
} finally {
lock.readLock().unlock();
}
}

/**
* Returns count of healthy metadata volumes reported from datanode.
* @return count of healthy metdata log volumes
Expand Down
52 changes: 52 additions & 0 deletions hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.util.concurrent.ScheduledFuture;
import java.util.concurrent.TimeUnit;
import java.util.function.Predicate;
import java.util.stream.Collectors;

import org.apache.hadoop.hdds.conf.ConfigurationSource;
import org.apache.hadoop.hdds.protocol.DatanodeDetails;
Expand Down Expand Up @@ -477,6 +478,38 @@ public List<DatanodeInfo> getDeadNodes() {
return getNodes(null, NodeState.DEAD);
}

/**
* Returns all nodes that are in the decommissioning state.
* @return list of decommissioning nodes
*/
public List<DatanodeInfo> getDecommissioningNodes() {
return getNodes(NodeOperationalState.DECOMMISSIONING, null);
}

/**
* Returns the count of decommissioning nodes.
* @return decommissioning node count
*/
public int getDecommissioningNodeCount() {
return getDecommissioningNodes().size();
}

/**
* Returns all nodes that are in the entering maintenance state.
* @return list of entering maintenance nodes
*/
public List<DatanodeInfo> getEnteringMaintenanceNodes() {
return getNodes(NodeOperationalState.ENTERING_MAINTENANCE, null);
}

/**
* Returns the count of entering maintenance nodes.
* @return entering maintenance node count
*/
public int getEnteringMaintenanceNodeCount() {
return getEnteringMaintenanceNodes().size();
}

/**
* Returns all the nodes with the specified status.
*
Expand All @@ -501,6 +534,25 @@ public List<DatanodeInfo> getNodes(
return nodeStateMap.getDatanodeInfos(opState, health);
}

/**
* Returns all nodes that contain failed volumes.
* @return list of nodes containing failed volumes
*/
public List<DatanodeInfo> getVolumeFailuresNodes() {
List<DatanodeInfo> allNodes = nodeStateMap.getAllDatanodeInfos();
List<DatanodeInfo> failedVolumeNodes = allNodes.stream().
filter(dn -> dn.getFailedVolumeCount() > 0).collect(Collectors.toList());
return failedVolumeNodes;
}

/**
* Returns the count of nodes containing the failed volume.
* @return failed volume node count
*/
public int getVolumeFailuresNodeCount() {
return getVolumeFailuresNodes().size();
}

/**
* Returns all the nodes which have registered to NodeStateManager.
*
Expand Down
30 changes: 30 additions & 0 deletions hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1223,6 +1223,8 @@ public Map<String, String> getNodeStatistics() {
Map<String, String> nodeStatistics = new HashMap<>();
// Statistics node usaged
nodeUsageStatistics(nodeStatistics);
// Statistics node states
nodeStateStatistics(nodeStatistics);
// todo: Statistics of other instances
return nodeStatistics;
}
Expand Down Expand Up @@ -1265,6 +1267,19 @@ private void nodeUsageStatistics(Map<String, String> nodeStatics) {
nodeStatics.put(UsageStatics.STDEV.getLabel(), decimalFormat.format(dev));
}

private void nodeStateStatistics(Map<String, String> nodeStatics) {
int healthyNodeCount = nodeStateManager.getHealthyNodeCount();
int deadNodeCount = nodeStateManager.getDeadNodeCount();
int decommissioningNodeCount = nodeStateManager.getDecommissioningNodeCount();
int enteringMaintenanceNodeCount = nodeStateManager.getEnteringMaintenanceNodeCount();
int volumeFailuresNodeCount = nodeStateManager.getVolumeFailuresNodeCount();
nodeStatics.put(StateStatistics.HEALTHY.getLabel(), String.valueOf(healthyNodeCount));
nodeStatics.put(StateStatistics.DEAD.getLabel(), String.valueOf(deadNodeCount));
nodeStatics.put(StateStatistics.DECOMMISSIONING.getLabel(), String.valueOf(decommissioningNodeCount));
nodeStatics.put(StateStatistics.ENTERING_MAINTENANCE.getLabel(), String.valueOf(enteringMaintenanceNodeCount));
nodeStatics.put(StateStatistics.VOLUME_FAILURES.getLabel(), String.valueOf(volumeFailuresNodeCount));
}

/**
* Based on the current time and the last heartbeat, calculate the time difference
* and get a string of the relative value. E.g. "2s ago", "1m 2s ago", etc.
Expand Down Expand Up @@ -1346,6 +1361,21 @@ public String getLabel() {
}
}

private enum StateStatistics {
HEALTHY("Healthy"),
DEAD("Dead"),
DECOMMISSIONING("Decommissioning"),
ENTERING_MAINTENANCE("EnteringMaintenance"),
VOLUME_FAILURES("VolumeFailures");
private String label;
public String getLabel() {
return label;
}
StateStatistics(String label) {
this.label = label;
}
}

/**
* Returns the min of no healthy volumes reported out of the set
* of datanodes constituting the pipeline.
Expand Down
32 changes: 31 additions & 1 deletion hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ <h2>SCM Information</h2>
</tbody>
</table>

<h2>Statistics</h2>
<h2>Usage Statistics</h2>
<table class="table table-bordered table-striped">
<tbody>
<tr>
Expand All @@ -54,6 +54,36 @@ <h2>Statistics</h2>
</tbody>
</table>

<h2>State Statistics</h2>
<table class="table table-bordered table-striped">
<tbody>
<tr>
<th>Datanode State</th>
<th>Count</th>
</tr>
<tr>
<td>Healthy Nodes</td>
<td>{{statistics.nodes.state.healthy}}</td>
</tr>
<tr>
<td>Dead Nodes</td>
<td>{{statistics.nodes.state.dead}}</td>
</tr>
<tr>
<td>Decommissioning Nodes</td>
<td>{{statistics.nodes.state.decommissioning}}</td>
</tr>
<tr>
<td>Entering Maintenance Nodes</td>
<td>{{statistics.nodes.state.enteringmaintenance}}</td>
</tr>
<tr>
<td>Volume Failures Nodes</td>
<td>{{statistics.nodes.state.volumefailures}}</td>
</tr>
</tbody>
</table>

<h2>Node Status</h2>
<div class="row">
<div class="col-md-6 text-left">
Expand Down
35 changes: 26 additions & 9 deletions hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@
max : "N/A",
median : "N/A",
stdev : "N/A"
},
state : {
healthy : "N/A",
dead : "N/A",
decommissioning : "N/A",
enteringmaintenance : "N/A",
volumefailures : "N/A"
}
}
}
Expand Down Expand Up @@ -92,15 +99,25 @@
$scope.lastIndex = Math.ceil(nodeStatusCopy.length / $scope.RecordsToDisplay);
$scope.nodeStatus = nodeStatusCopy.slice(0, $scope.RecordsToDisplay);

ctrl.nodemanagermetrics.NodeStatistics.forEach(function(obj) {
if(obj.key == "Min") {
$scope.statistics.nodes.usages.min = obj.value;
} else if(obj.key == "Max") {
$scope.statistics.nodes.usages.max = obj.value;
} else if(obj.key == "Median") {
$scope.statistics.nodes.usages.median = obj.value;
} else if(obj.key == "Stdev") {
$scope.statistics.nodes.usages.stdev = obj.value;
ctrl.nodemanagermetrics.NodeStatistics.forEach(({key, value}) => {
if(key == "Min") {
$scope.statistics.nodes.usages.min = value;
} else if(key == "Max") {
$scope.statistics.nodes.usages.max = value;
} else if(key == "Median") {
$scope.statistics.nodes.usages.median = value;
} else if(key == "Stdev") {
$scope.statistics.nodes.usages.stdev = value;
} else if(key == "Healthy") {
$scope.statistics.nodes.state.healthy = value;
} else if(key == "Dead") {
$scope.statistics.nodes.state.dead = value;
} else if(key == "Decommissioning") {
$scope.statistics.nodes.state.decommissioning = value;
} else if(key == "EnteringMaintenance") {
$scope.statistics.nodes.state.enteringmaintenance = value;
} else if(key == "VolumeFailures") {
$scope.statistics.nodes.state.volumefailures = value;
}
});
});
Expand Down