HDDS-11260. [hsync] Add Ozone Manager protocol version #7015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenSammi
reviewed
Aug 1, 2024
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyOutputStream.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Aug 1, 2024
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
Outdated
Show resolved
Hide resolved
errose28
reviewed
Aug 1, 2024
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks for adding this @jojochuang
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyOutputStream.java
Outdated
Show resolved
Hide resolved
...one/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Address review comments.
Please enter the commit message for your changes. Lines starting |
ChenSammi
approved these changes
Aug 2, 2024
Contributor
There was a problem hiding this comment.
LGTM. Thanks @jojochuang . Waiting for CI to pass.
Change-Id: Id9a7ca230708451e2d78a43e2da26c4dd8f554d2
Change-Id: Id6c63ef31fa30698eca2ce53f5fdbf95c9aef5d2
… don't support HBASE_SUPPORT protocol version. Change-Id: I2dcf1c8d1903e521c91bc4cb0c6570ab4057d81e
1. Remove the redundant typecast from ClientProtocol to RpcClient. 2. Replace IOException with UnsupportedOperationException for better application handling. 3. Better exception description. Change-Id: Icb54c1b616820f8d93d6db9dc90c8dea4a6c19e1
Contributor
Author
|
The PR CI passed but I still want to double check. |
errose28
approved these changes
Aug 2, 2024
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks for the updates, LGTM
Contributor
Author
|
Merged. Thanks @errose28 and @ChenSammi |
Contributor
|
Thanks @jojochuang for the patch. |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Aug 7, 2024
* master: (181 commits) HDDS-11289. Bump docker-maven-plugin to 0.45.0 (apache#7024) HDDS-11287. Code cleanup in XceiverClientSpi (apache#7043) HDDS-11283. Refactor KeyValueStreamDataChannel to avoid spurious IDE build issues (apache#7040) HDDS-11257. Ozone write does not work when http proxy is set for the JVM. (apache#7036) HDDS-11249. Bump ozone-runner to 20240729-jdk17-1 (apache#7003) HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info (apache#6724) HDDS-11270. [hsync] Add DN layout version (HBASE_SUPPORT/version 8) upgrade test. (apache#7021) HDDS-11272. Statistics some node status information (apache#7025) HDDS-11278. Move code out of Hadoop util package (apache#7028) HDDS-11274. (addendum) Replace Hadoop annotations/configs with Ozone-specific ones HDDS-11274. Replace Hadoop annotations/configs with Ozone-specific ones (apache#7026) HDDS-11280. Add Synchronize in AbstractCommitWatcher.addAckDataLength (apache#7032) HDDS-11235. Spare InfoBucket RPC call in FileSystem#mkdir() call. (apache#6990) HDDS-11273. Bump commons-compress to 1.26.2 (apache#7023) HDDS-11225. Increase ipc.server.read.threadpool.size (apache#7007) HDDS-11224. Increase hdds.datanode.handler.count (apache#7011) HDDS-11259. [hsync] DataNode should verify HBASE_SUPPORT layout version for every PutBlock. (apache#7012) HDDS-11214. Added config to set rocksDB's max log file size and num of log files (apache#7014) HDDS-11226. Make ExponentialBackoffPolicy maxRetries configurable (apache#6985) HDDS-11260. [hsync] Add Ozone Manager protocol version (apache#7015) ... Conflicts: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/audit/DNAction.java hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/TestContainerReportHandler.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-11260. [hsync] Add Ozone Manager protocol version
Please describe your PR in detail:
Add a new Ozone Manager layout version HBASE_SUPPORT and prevent clients to submit HBase related requests (hsync, listOpenFiles, recoverLease) to OM if OM isn't upgraded yet.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11260
How was this patch tested?