Skip to content

HDDS-11214. Added config to set rocksDB's max log file size and num of log files #7014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hemantk-12 merged 1 commit into from
Aug 2, 2024
Merged

HDDS-11214. Added config to set rocksDB's max log file size and num of log files #7014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStoreBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,10 @@ private ManagedDBOptions getDefaultDBOptions(
dbOptions.setLogger(logger);
}

// RocksDB log settings.
dbOptions.setMaxLogFileSize(rocksDBConfiguration.getMaxLogFileSize());
dbOptions.setKeepLogFileNum(rocksDBConfiguration.getKeepLogFileNum());

// Apply WAL settings.
dbOptions.setWalTtlSeconds(rocksDBConfiguration.getWalTTL());
dbOptions.setWalSizeLimitMB(rocksDBConfiguration.getWalSizeLimit());
Expand Down
30 changes: 30 additions & 0 deletions ...op-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RocksDBConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,20 @@ public class RocksDBConfiguration {
description = "OM RocksDB logging level (INFO/DEBUG/WARN/ERROR/FATAL)")
private String rocksdbLogLevel;

@Config(key = "rocksdb.max.log.file.size",
type = ConfigType.SIZE,
defaultValue = "0MB",
tags = {OM, SCM, DATANODE},
description = "Maximum size of RocksDB application log file.")
private long rocksdbMaxLogFileSize = 0;

@Config(key = "rocksdb.keep.log.file.num",
type = ConfigType.INT,
defaultValue = "1000",
tags = {OM, SCM, DATANODE},
description = "Maximum number of RocksDB application log files.")
private int rocksdbKeepLogFileNum = 1000;

@Config(key = "rocksdb.writeoption.sync",
type = ConfigType.BOOLEAN,
defaultValue = "false",
Expand Down Expand Up @@ -110,4 +124,20 @@ public void setWalSizeLimit(long limit) {
public long getWalSizeLimit() {
return walSizeLimit;
}

public void setMaxLogFileSize(long fileSize) {
rocksdbMaxLogFileSize = fileSize;
}

public long getMaxLogFileSize() {
return rocksdbMaxLogFileSize;
}

public void setKeepLogFileNum(int fileNum) {
rocksdbKeepLogFileNum = fileNum;
}

public int getKeepLogFileNum() {
return rocksdbKeepLogFileNum;
}
}