HDDS-11236. Move Java version-specific NETTY_OPTS to ozone-functions.sh

[sarvekshayr]

What changes were proposed in this pull request?

HDDS-10382 introduced Java-version specific logic for Netty, we will move the setting of NETTY_OPTS to the ozone_java_setup function in hadoop-ozone/dist/src/shell/ozone/ozone-functions.sh.
This will centralize the configuration and ensure compatibility with the existing RATIS_OPTS settings.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11236

How was this patch tested?

Tested the patch locally on a docker cluster.

recon-1     | DEBUG: Final OZONE_OPTS: -Djava.net.preferIPv4Stack=true  -Dorg.apache.ratis.thirdparty.io.netty.allocator.useCacheForAllThreads=false -Dorg.apache.ratis.thirdparty.io.netty.tryReflectionSetAccessible=true   --add-opens java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED --add-exports java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED --add-opens java.base/java.nio=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.reflect=ALL-UNNAMED -XX:ParallelGCThreads=8 -Dhadoop.log.dir=/var/log/hadoop -Dhadoop.log.file=ozone.log -Dhadoop.home.dir=/opt/hadoop -Dhadoop.id.str=hadoop -Dhadoop.root.logger=INFO,console -Dhadoop.policy.file=hadoop-policy.xml -Dhadoop.security.logger=INFO,NullAppender
scm-1       | DEBUG: Final OZONE_OPTS: -Djava.net.preferIPv4Stack=true -Dlog4j2.contextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector -Dorg.apache.ratis.thirdparty.io.netty.allocator.useCacheForAllThreads=false -Dorg.apache.ratis.thirdparty.io.netty.tryReflectionSetAccessible=true   -Dlog4j.configurationFile=/etc/hadoop/scm-audit-log4j2.properties  --add-opens java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED --add-exports java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED --add-opens java.base/java.nio=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.reflect=ALL-UNNAMED -XX:ParallelGCThreads=8 -Dhadoop.log.dir=/var/log/hadoop -Dhadoop.log.file=ozone.log -Dhadoop.home.dir=/opt/hadoop -Dhadoop.id.str=hadoop -Dhadoop.root.logger=INFO,console -Dhadoop.policy.file=hadoop-policy.xml -Dhadoop.security.logger=INFO,NullAppender

[tanvipenumudy]

Thanks for the patch, @sarvekshayr. Overall, the changes look good.

[adoroszlai]

Thanks @sarvekshayr for the patch.

FYI, setting OZONE_SHELL_SCRIPT_DEBUG=true will make Ozone print OZONE_OPTS (among other debug messages), which is useful for testing:

ozone-datanode-1 | DEBUG: Final OZONE_OPTS: -Djava.net.preferIPv4Stack=true -Dlog4j2.contextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector -Dlog4j.configurationFile=/etc/hadoop/dn-audit-log4j2.properties,/etc/hadoop/dn-container-log4j2.properties -Dorg.apache.ratis.thirdparty.io.netty.allocator.useCacheForAllThreads=false -Dorg.apache.ratis.thirdparty.io.netty.tryReflectionSetAccessible=true    --add-opens java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED --add-exports java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED --add-opens java.base/java.nio=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.reflect=ALL-UNNAMED -XX:ParallelGCThreads=8 -Dhadoop.log.dir=/var/log/hadoop -Dhadoop.log.file=ozone.log -Dhadoop.home.dir=/opt/hadoop -Dhadoop.id.str=hadoop -Dhadoop.root.logger=INFO,console -Dhadoop.policy.file=hadoop-policy.xml -Dhadoop.security.logger=INFO,NullAppender

[adoroszlai]

Thanks @sarvekshayr for the patch, @tanvipenumudy for the review.