HDDS-11238. Converge redundant getBucket calls for FileSystem client delete #6991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Jul 27, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @tanvipenumudy for the patch. Some improvements suggested.
...zone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java
Outdated
Show resolved
Hide resolved
...zone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java
Outdated
Show resolved
Hide resolved
...zone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java
Outdated
Show resolved
Hide resolved
...zone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java
Outdated
Show resolved
Hide resolved
…/ozone/BasicRootedOzoneFileSystem.java Co-authored-by: Doroszlai, Attila <[email protected]>
…/ozone/BasicRootedOzoneFileSystem.java Co-authored-by: Doroszlai, Attila <[email protected]>
…/ozone/BasicRootedOzoneFileSystem.java Co-authored-by: Doroszlai, Attila <[email protected]>
ArafatKhan2198
requested changes
Jul 29, 2024
Contributor
ArafatKhan2198
left a comment
ArafatKhan2198
left a comment
There was a problem hiding this comment.
Thanks for the changes @tanvipenumudy overall the patch looks good.
Can you please address the one comment I have given.
...zone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java
Show resolved
Hide resolved
ArafatKhan2198
approved these changes
Jul 29, 2024
Contributor
ArafatKhan2198
left a comment
ArafatKhan2198
left a comment
There was a problem hiding this comment.
Thanks for updating the patch @tanvipenumudy
LGTM
adoroszlai
reviewed
Jul 29, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @tanvipenumudy for updating the patch, LGTM.
tanvipenumudy
changed the title
Contributor
Author
|
Thanks @adoroszlai and @ArafatKhan2198 for reviewing the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A few internal calls as part of FileSystem client delete involve repeated computation of getBucket(). Instead, we may precompute the OzoneBucket object and then pass it onto other dependent calls as they again compute the same object internally.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11238
How was this patch tested?
Existing unit and integration tests should cover the changes