HDDS-11228. Ozone Recon HeatMap refactoring of code. #6986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ArafatKhan2198 kindly review. Just a refactor of existing code. |
ArafatKhan2198
requested changes
Jul 25, 2024
Contributor
ArafatKhan2198
left a comment
ArafatKhan2198
left a comment
There was a problem hiding this comment.
Thanks for the patch @devmadhuu
Overall, the refactoring looks good, just one comment to consider.
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/AccessHeatMapEndpoint.java
Show resolved
Hide resolved
ArafatKhan2198
approved these changes
Jul 25, 2024
Contributor
ArafatKhan2198
left a comment
ArafatKhan2198
left a comment
There was a problem hiding this comment.
Thanks for the changes @devmadhuu LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR change is only to refactor heatmap code to have better readability and maintainability.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11228
How was this patch tested?
Patch tested manually.