HDDS-11215. Quota count can go wrong when double buffer flush takes time #6978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadanand48
approved these changes
Jul 22, 2024
Contributor
sadanand48
left a comment
sadanand48
left a comment
There was a problem hiding this comment.
Thanks @sumitagrawl for finding this issue. patch LGTM
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 26, 2024
…ime. (apache#6978) (cherry picked from commit 19f9afb)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 26, 2024
…ime. (apache#6978) (cherry picked from commit 19f9afb)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 26, 2024
…ime. (apache#6978) (cherry picked from commit 19f9afb)
ptlrs
pushed a commit
to ptlrs/ozone
that referenced
this pull request
Mar 8, 2025
…lush takes time. (apache#6978) (apache#81) (cherry picked from commit 19f9afb) Co-authored-by: Sumit Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
bucketInfo can have incorrect count, and even can go -ve value. This is as DirectoryDeletingService keeps sending purgeDirectory request till rocksdb delectedDirectoryTable is not flushed with deletion. For the fix,
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11215
How was this patch tested?