Skip to content

HDDS-11132. Update the OLDER_CLIENT_REQUEST validations to check against bucket types. #6919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sadanand48 wants to merge 4 commits into from
Closed

HDDS-11132. Update the OLDER_CLIENT_REQUEST validations to check against bucket types. #6919

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1bb689e
HDDS-11133. Update the OLDER_CLIENT_REQUEST validations to check agai…
Jul 10, 2024
100fe0a
rename condition
Jul 10, 2024
c011772
fix CI failure and add unit test
Jul 10, 2024
5d1f73a
fix checkstyle
Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/ClientVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ public int toProtoValue() {
return version;
}

public int getVersion() {
return version;
}

public static ClientVersion fromProtoValue(int value) {
return BY_PROTO_VALUE.getOrDefault(value, FUTURE_VERSION);
}
Expand Down
2 changes: 1 addition & 1 deletion ...ager/src/main/java/org/apache/hadoop/ozone/om/request/validation/ValidationCondition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public boolean shouldApply(OMRequest req, ValidationContext ctx) {
OLDER_CLIENT_REQUESTS {
@Override
public boolean shouldApply(OMRequest req, ValidationContext ctx) {
return req.getVersion() < ClientVersion.CURRENT_VERSION;
return req.getVersion() < ClientVersion.BUCKET_LAYOUT_SUPPORT.getVersion();
}
};

Expand Down