HDDS-11112. Verify javadoc creation in CI #6910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadanand48
reviewed
Jul 10, 2024
sadanand48
approved these changes
Jul 10, 2024
Contributor
sadanand48
left a comment
sadanand48
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai for the patch, LGTM.
Contributor
Author
|
Thanks @sadanand48 for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Javadoc is generated only with the
distprofile. This is used in CI build, but Javadoc is explicitly skipped. Thus, javadoc generation is currently exercised only when making release candidates.This change enables Javadoc generation in the
compilecheck. Build is successful despite Javadoc problems, e.g.:We can enable
failOnWarningafter fixing these warnings. The current change would help catch problems with usage ofmaven-javadoc-pluginitself (e.g. wrong version or config).https://issues.apache.org/jira/browse/HDDS-11112
How was this patch tested?
Verified
maven-javadoc-pluginis executed incompilecheck:https://github.com/adoroszlai/ozone/actions/runs/9828984546/job/27133798734#step:8:3488