HDDS-11023. Recon Disk Usage null conditions not handled properly for null response

[smitajoshi12]

What changes were proposed in this pull request?

To avoid null conditions on Disk Usage page

Please describe your PR in detail:

When Recon was intializing on Disk Usage page we were getting failures as values are not mapped properly so to avoid such conditions added checks.

API Response :

api/v1/namespace/du?path=/&files=true&sortSubPaths=true

{ "status": "INITIALIZING", "path": null, "size": 0, "sizeWithReplica": -1, "subPathCount": 0, "subPaths": [], "sizeDirectKey": -1 }

---

api/v1/namespace/summary?path=null

{ "path": "", "type": "UNKNOWN", "countStats": null, "objectInfo": null, "status": "INITIALIZING" }

---

/api/v1/namespace/quota?path=null

{"allowed":0,"used":0,"status":"INITIALIZING"}

What is the link to the Apache JIRA

(https://issues.apache.org/jira/browse/HDDS-11023)

How was this patch tested?

Manually

Before this PR

With this Patch

[smitajoshi12]

@devabhishekpal @dombizita @devmadhuu @ArafatKhan2198

Can you review this pr

[ArafatKhan2198]

Thanks for the patch @smitajoshi12
Some minor comments

[devabhishekpal]

Thanks @smitajoshi12 , the patch looks good to me now.

Please do take a look at @ArafatKhan2198's comment for replica=false and raise the JIRA.

[smitajoshi12]

Thanks @smitajoshi12 , the patch looks good to me now.

Please do take a look at @ArafatKhan2198's comment for replica=false and raise the JIRA.

@devabhishekpal
It is already raised. [(https://issues.apache.org/jira/browse/HDDS-11140)]

[ArafatKhan2198]

Thanks for working on this patch, @smitajoshi12 I appreciate you catching this issue and implementing the necessary changes. However, I believe we can present the information displayed to the user about Namespace initialization in a much clearer way, as the Namespace can be in initialization mode for two specific reasons:

1. The metadata is too large and is taking time to initialize.
2. The OM snapshot has not yet been fetched from the OM.

It's important for the user to know that there is no problem with the data; rather, there is just a delay in building the NSSummary. Instead of having the user click the "Show Metadata for Current Path" button, we should display a pop-up message. This message should not be an alert but a simple notification indicating that the state is initializing and that they need to wait.

Additionally, the error message shown in the screenshot can be improved to something more user-friendly like:

"Metadata Initialization: The metadata is currently initializing. Please wait a moment and try again later.”

[smitajoshi12]

Thanks for working on this patch, @smitajoshi12 I appreciate you catching this issue and implementing the necessary changes. However, I believe we can present the information displayed to the user about Namespace initialization in a much clearer way, as the Namespace can be in initialization mode for two specific reasons:

1. The metadata is too large and is taking time to initialize.
2. The OM snapshot has not yet been fetched from the OM.

It's important for the user to know that there is no problem with the data; rather, there is just a delay in building the NSSummary. Instead of having the user click the "Show Metadata for Current Path" button, we should display a pop-up message. This message should not be an alert but a simple notification indicating that the state is initializing and that they need to wait.

Additionally, the error message shown in the screenshot can be improved to something more user-friendly like:

"Metadata Initialization: The metadata is currently initializing. Please wait a moment and try again later.”

@ArafatKhan2198
Completed Changes suggested by you attached screenshot with Info Notification

[devabhishekpal]

Added minor check changes to use optional chaining instead

[ArafatKhan2198]

Thanks @smitajoshi12 for the patch overall the changes look good.
Just a few more minor comments

[ArafatKhan2198]

@devabhishekpal Can you please go through your comments and resolve them if they have been fixed in the patch.

[devabhishekpal]

Thanks @smitajoshi12 for the changes.
Please do take a look at @ArafatKhan2198's comments.
Apart from that it looks good to me, +1

[smitajoshi12]

@ArafatKhan2198
Completed all changes can you merge this pr.

[ArafatKhan2198]

@smitajoshi12 Most of the changes look good, but I noticed something odd while testing this patch on a cluster. When there is supposed to be no data in the cluster except for a volume named S3V, clicking the "Show Metadata" button should display the NSSummary for the root ("/") path. However, we're encountering an error instead. I'm not sure if this issue was introduced by this patch, but could you please look into it as well?

[devmadhuu]

Thanks @smitajoshi12 for improving the patch. Changes LGTM +1. Thanks @ArafatKhan2198 @dombizita @devabhishekpal for review.

[smitajoshi12]

@smitajoshi12 Most of the changes look good, but I noticed something odd while testing this patch on a cluster. When there is supposed to be no data in the cluster except for a volume named S3V, clicking the "Show Metadata" button should display the NSSummary for the root ("/") path. However, we're encountering an error instead. I'm not sure if this issue was introduced by this patch, but could you please look into it as well?

@ArafatKhan2198 @devpalabhishek
Optional Chaining not working summaryResponse.objectInfo?.replicationConfig?.replicationFactor !== -1 Instead -1 need to check conditions for undefined also

{
"path": "",
"type": "ROOT",
"countStats": {
"numVolume": 1,
"numBucket": 0,
"numDir": 0,
"numKey": 0
},
"objectInfo": {
"metadata": null,
"name": null,
"quotaInBytes": 0,
"quotaInNamespace": 0,
"usedNamespace": 0,
"creationTime": 0,
"modificationTime": 0,
"acls": null
},
"status": "OK"
}

[smitajoshi12]

@smitajoshi12 Most of the changes look good, but I noticed something odd while testing this patch on a cluster. When there is supposed to be no data in the cluster except for a volume named S3V, clicking the "Show Metadata" button should display the NSSummary for the root ("/") path. However, we're encountering an error instead. I'm not sure if this issue was introduced by this patch, but could you please look into it as well?

@ArafatKhan2198 @devpalabhishek Optional Chaining not working summaryResponse.objectInfo?.replicationConfig?.replicationFactor !== -1 Instead -1 need to check conditions for undefined also

{ "path": "", "type": "ROOT", "countStats": { "numVolume": 1, "numBucket": 0, "numDir": 0, "numKey": 0 }, "objectInfo": { "metadata": null, "name": null, "quotaInBytes": 0, "quotaInNamespace": 0, "usedNamespace": 0, "creationTime": 0, "modificationTime": 0, "acls": null }, "status": "OK" }

@ArafatKhan2198 Thanks for pointing out undefined condition. In Latest commit I. have handled both undefined and -1 condition from API response.

[devabhishekpal]

Thanks for the changes @smitajoshi12.
Thanks for reviewing the change @ArafatKhan2198, @devmadhuu, @dombizita