HDDS-11084. Read SstFilteringService config once and reuse it in SnapshotDeletingService #6885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shotDeletingService
sadanand48
approved these changes
Jun 29, 2024
Contributor
sadanand48
left a comment
sadanand48
left a comment
There was a problem hiding this comment.
Thanks @hemantk-12 for the patch, LGTM.
swamirishi
approved these changes
Jun 30, 2024
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
Thanks for the patch @hemantk-12 LGTM
Contributor
|
Thanks @hemantk-12 for the patch, @sadanand48, @swamirishi for the review. |
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Oct 1, 2024
…tingService (apache#6885) (cherry picked from commit 950a4b5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, SnapshotDeletingService calls KeyManagerImpl#isSstFilteringSvcEnabled() for each snapshot while iterating over snapshotInfoTable. It reads the config every time which is a redundant call. Since the config can not be changed after the service's startup dynamically, we can change the code to read the config once and reuse it.
What is the link to the Apache JIRA
HDDS-11084
How was this patch tested?
Unit tests.