HDDS-11045. Recon Decommissioning Info API throws NPE. #6862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ArafatKhan2198 @sumitagrawl pls review. |
Contributor
ArafatKhan2198
left a comment
ArafatKhan2198
left a comment
There was a problem hiding this comment.
Thanks for the patch @devmadhuu the changes look good to me.
Just a few minor suggestions to implement if possible.
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/DecommissionUtils.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/DecommissionUtils.java
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks for the patch @devmadhuu and @sumitagrawl for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to fix the NullPointerException for datanode tag in Decommissioning Info API JSON.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11045
How was this patch tested?
Patch was tested manually with existing Junit test cases.