HDDS-10923. Container Scanner should still scan unhealthy containers. #6809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerneltime
reviewed
Jun 18, 2024
...iner-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java
Show resolved
Hide resolved
errose28
reviewed
Jun 18, 2024
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks @aswinshakil LGTM once we add tests that already unhealthy containers are getting re-scanned.
...src/test/java/org/apache/hadoop/ozone/container/ozoneimpl/TestContainerScannersAbstract.java
Show resolved
Hide resolved
...iner-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java
Show resolved
Hide resolved
errose28
reviewed
Jun 21, 2024
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks @aswinshakil just a few more updates based on the test changes.
...est/java/org/apache/hadoop/ozone/container/ozoneimpl/TestBackgroundContainerDataScanner.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/hadoop/ozone/container/ozoneimpl/TestBackgroundContainerDataScanner.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/hadoop/ozone/container/ozoneimpl/TestOnDemandContainerDataScanner.java
Outdated
Show resolved
Hide resolved
kerneltime
approved these changes
Jun 24, 2024
errose28
reviewed
Jun 25, 2024
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Just one minor comment on the test updates then this looks good from me.
...est/java/org/apache/hadoop/ozone/container/ozoneimpl/TestBackgroundContainerDataScanner.java
Show resolved
Hide resolved
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Jun 28, 2024
…-delete * HDDS-10239-container-reconciliation: HDDS-10887. Implement a basic Merkle Tree Manager. (apache#6778) HDDS-10923. Container Scanner should still scan unhealthy containers. (apache#6809) Conflicts: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/checksum/ContainerChecksumTreeManager.java hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/checksum/TestContainerChecksumTreeManager.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently the container scanner skips containers which are already marked as unhealthy. Now that the we want to either repair these containers, or use parts of them to repair other containers. We need the container scanner to scan UNHEALTHY container as well.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10923
How was this patch tested?
Existing Tests.