HDDS-10843. Enhance rewrite test to cover all key attributes #6799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanvipenumudy
approved these changes
Jun 10, 2024
Contributor
tanvipenumudy
left a comment
tanvipenumudy
left a comment
There was a problem hiding this comment.
Thank you @adoroszlai for the patch, LGTM.
| void overwriteAfterRewrite(BucketLayout layout) throws IOException { | ||
| OzoneBucket bucket = createBucket(layout); | ||
| OzoneKeyDetails keyDetails = createTestKey(bucket); | ||
| OmKeyArgs keyArgs = toOmKeyArgs(keyDetails); |
Contributor
There was a problem hiding this comment.
NIT: I think we can remove this line since it is not being used.
Suggested change
| OmKeyArgs keyArgs = toOmKeyArgs(keyDetails); |
Contributor
Author
There was a problem hiding this comment.
Thanks, removed leftover variable.
Contributor
Author
|
Thanks @sodonnel, @tanvipenumudy for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add assertions about
OmKeyInfoandOzoneKeyattributes for tests covering rewrite.https://issues.apache.org/jira/browse/HDDS-10843
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/9448431396