-
Notifications
You must be signed in to change notification settings - Fork 593
HDDS-10941. Add a few interesting ContainerStateMachine metrics in CSMMetrics #6782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xichen01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jojochuang Thanks for the patch, you can refer to some comments
...rc/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/CSMMetrics.java
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/CSMMetrics.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/CSMMetrics.java
Show resolved
Hide resolved
duongkame
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jojochuang for the patch, LGTM.
| ContainerCommandResponseProto proto = dispatchCommand(request, context); | ||
| return proto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ContainerCommandResponseProto proto = dispatchCommand(request, context); | |
| return proto; | |
| return dispatchCommand(request, context); | |
| ; |
|
As discussed offline, we'd also be interested in queueing delay and execution latency of |
…ansaction. Change-Id: I013ec37c2b18e7e164585a27e403bf52341fe6a7
Change-Id: Iad002201c447e3ca653b5fb86421068313206eb4
Change-Id: I6ac744943bd9c4dd1e2bae9810605eefd5486a3b (cherry picked from commit 582dbe590aa2c77bfd08dfeff08fd33f90e5193e)
Change-Id: I1881a54696f46ea7dec2db33e1eb2a0c62d03ad9
Change-Id: I4d81fb4ae063f5af830b5c327f6a1a391275f405
Change-Id: I7f9add68a4c26d521c94f98c1dd57090984b7750
e583478 to
9d20645
Compare
|
Rebased the PR. |
...rc/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/CSMMetrics.java
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/CSMMetrics.java
Outdated
Show resolved
Hide resolved
Change-Id: Ic0d440bd69cd4b754f18b10c7b48b0b1c70c100f
|
Is this good to go? @xichen01 @duongkame |
xichen01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM+1
|
Merged. Thanks @xichen01 @duongkame |
What changes were proposed in this pull request?
HDDS-10941. CSMMetrics to record number of started transactions
(1)
Add a label RaftGroupId so that Prometheus can identify different CSM instances by pipeline id. Previously, only one Container State Machine metrics instance is exported, which is confusing.
Add a few metrics for ContainerStateMachine operations.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10941
How was this patch tested?
Existing unit tests passed. https://github.com/jojochuang/ozone/actions/runs/9409277999/job/25918878051
Deployed a version of this PR on a real cluster and observed the metrics were exported properly.