Skip to content

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented May 31, 2024

What changes were proposed in this pull request?

This PR adds coverage for rewrite of key created via multipart upload. The test can be expanded later for other cases, but atomic key rewrite is already (mostly) covered by integration tests for regular keys.

Most of this change is making some custom robot test keywords available for tests outside S3 tests.

https://issues.apache.org/jira/browse/HDDS-10947

How was this patch tested?

CI:
https://github.com/adoroszlai/ozone/actions/runs/9317350415/job/25648077188#step:5:366

Verified that the key was originally created via multipart upload:

2024-05-31 16:26:22,635 | INFO  | OMAudit | user=dlfknslnfslf | ip=192.168.96.9 | op=INITIATE_MULTIPART_UPLOAD {volume=s3v, bucket=bucket-bcqjqldpje, key=multipart.key, dataSize=0} | ret=SUCCESS |  
2024-05-31 16:26:23,441 | INFO  | OMAudit | user=dlfknslnfslf | ip=192.168.96.9 | op=COMMIT_MULTIPART_UPLOAD_PARTKEY {volume=s3v, bucket=bucket-bcqjqldpje, key=multipart.key, dataSize=4194304, ETag=7e545caeb052915b4e76bbdf290c5c3a, partNumber=2, partName=/s3v/bucket-bcqjqldpje/multipart.key-0ac48c33-a70c-4cd0-935a-e2322d7495e2-112536635482112000-2} | ret=SUCCESS |  
2024-05-31 16:26:23,563 | INFO  | OMAudit | user=dlfknslnfslf | ip=192.168.96.9 | op=COMMIT_MULTIPART_UPLOAD_PARTKEY {volume=s3v, bucket=bucket-bcqjqldpje, key=multipart.key, dataSize=8388608, ETag=f4e411ff337150ed3523d5d46e4babdc, partNumber=1, partName=/s3v/bucket-bcqjqldpje/multipart.key-0ac48c33-a70c-4cd0-935a-e2322d7495e2-112536635482112000-1} | ret=SUCCESS |  
2024-05-31 16:26:23,591 | INFO  | OMAudit | user=dlfknslnfslf | ip=192.168.96.9 | op=COMPLETE_MULTIPART_UPLOAD {volume=s3v, bucket=bucket-bcqjqldpje, key=multipart.key, dataSize=0, multipartList=[partNumber: 1 partName: "f4e411ff337150ed3523d5d46e4babdc" eTag: "f4e411ff337150ed3523d5d46e4babdc" , partNumber: 2 partName: "7e545caeb052915b4e76bbdf290c5c3a" eTag: "7e545caeb052915b4e76bbdf290c5c3a" ]} | ret=SUCCESS |  

@adoroszlai adoroszlai self-assigned this May 31, 2024
@adoroszlai adoroszlai requested a review from sodonnel May 31, 2024 12:37
Copy link
Contributor

@sodonnel sodonnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for increasing the test coverage in this area.

@adoroszlai adoroszlai merged commit 8c04d72 into apache:HDDS-10656-atomic-key-overwrite Jun 2, 2024
@adoroszlai adoroszlai deleted the HDDS-10947 branch June 2, 2024 06:39
@adoroszlai
Copy link
Contributor Author

Thanks @sodonnel for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants