HDDS-10924. TestSCMHAManagerImpl#testAddSCM fails on ratis master #6753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Should we just mock to provide a null checkpoint, like this |
Contributor
Author
Since this is a unit test for |
nandakumar131
approved these changes
May 31, 2024
Contributor
|
Thanks @adoroszlai for the quick fix and thanks @duongkame for taking a look at the fix. |
Contributor
Author
|
Thanks @nandakumar131 for the review. |
smengcl
pushed a commit
to smengcl/hadoop-ozone
that referenced
this pull request
Jun 7, 2024
…ache#6753) (cherry picked from commit 787c9d3)
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Jun 12, 2024
…ache#6753) (cherry picked from commit 787c9d3) (cherry picked from commit 64ac950)
chungen0126
pushed a commit
to chungen0126/ozone
that referenced
this pull request
Jun 27, 2024
…ache#6753) (cherry picked from commit 787c9d3)
jojochuang
pushed a commit
that referenced
this pull request
Jun 27, 2024
) (#6874) (cherry picked from commit 787c9d3) Co-authored-by: Doroszlai, Attila <[email protected]>
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 18, 2024
…ache#6753) (cherry picked from commit 787c9d3)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 18, 2024
…ache#6753) (cherry picked from commit 787c9d3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Tweak
TestSCMHAManagerImplto let it pass with Ratis 3.1.0.https://issues.apache.org/jira/browse/HDDS-10924
How was this patch tested?
Ozone CI with Ratis 3.1.0 RC0:
https://github.com/adoroszlai/ozone/actions/runs/9306740993
Regular CI:
https://github.com/adoroszlai/ozone/actions/runs/9306735813